fix(BA-4167): Use joinedload instead of selectinload in AgentDBSource.get_by_id
#8472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size:M
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes MissingGreenlet raised by AgentDBSource.get_by_id() when actual_occupied_slots computation touches the kernels relationship in async contexts.
Changes:
- Switch eager-loading strategy in
AgentDBSource.get_by_id()fromselectinloadtojoinedloadforAgentRow.kernels. - Add unit test coverage to validate
get_by_id()can computeactual_occupied_slotswithout triggering async lazy-loading. - Add changelog entry documenting the fix.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/ai/backend/manager/repositories/agent/db_source/db_source.py |
Changes eager-loading option used by get_by_id() for kernels. |
tests/unit/manager/repositories/agent/test_repository.py |
Adds a new test ensuring get_by_id() loads kernels and computes actual_occupied_slots. |
changes/8472.fix.md |
Adds a changelog note for the MissingGreenlet fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
seedspirit
force-pushed
the
fix/BA-4167
branch
from
c60831c to
5775c15
Compare
HyeockJinKim
requested changes
Jan 30, 2026
Comment on lines
917
to
927
| async def test_get_by_id_loads_kernels_and_computes_actual_occupied_slots( | ||
| self, | ||
| db_source: AgentDBSource, | ||
| agent_with_kernels: KernelFilteringTestCase, | ||
| ) -> None: | ||
| # Act - This should not raise MissingGreenlet error | ||
| agent_data = await db_source.get_by_id(agent_with_kernels.agent_id) | ||
|
|
||
| # Assert - Verify actual_occupied_slots is computed correctly | ||
| actual_cpu = agent_data.actual_occupied_slots.get("cpu", 0) | ||
| assert Decimal(str(actual_cpu)) == agent_with_kernels.expected_actual_occupied_cpu |
Collaborator
There was a problem hiding this comment.
We need to test the repository, but you are only testing the database source.
Contributor
Author
There was a problem hiding this comment.
Modified it to test the repository. Since test_search_agents_validates_actual_occupied_slots was also testing DBSource, changed it to test the repository as well.
…d of AgentDBSource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #8468 (BA-4167)
Checklist: (if applicable)
ai.backend.testdocsdirectory