feat(BA-4131): Add `ImageAlias` support to Strawberry GraphQL schema #8400

jopemachine · 2026-01-28T05:45:40Z

Summary

Add aliases field as a dynamic resolver to ImageV2GQL using the action-processor pattern
Implement DataLoader pattern to prevent N+1 query problems when loading aliases for multiple images

Changes

Create GetAliasesByImageIdsAction and GetAliasesByImageIdsActionResult action types
Add query_aliases_by_image_ids() method to ImageDBSource for batch querying aliases
Add get_aliases_by_image_ids() method to ImageRepository
Add get_aliases_by_image_ids() service handler to ImageService
Add get_aliases_by_image_ids processor to ImageProcessors
Create load_aliases_by_image_ids dataloader function
Add image_aliases_loader to DataLoaders class
Add aliases field resolver to ImageV2GQL type

Test plan

Query imagesV2 and verify aliases field returns correct alias list for each image
Query imageV2(id: ...) and verify aliases field resolves correctly
Verify DataLoader batches multiple alias requests into single database query

Add SearchImagesAction for batch loading images with BatchQuerier: - Add ImageListResult type for search results - Add search_images method to ImageDBSource and ImageRepository - Add SearchImagesAction with BatchQuerier support - Register search_images processor in ImageProcessors Part of BEP-1039: Image ID Based Service Logic Migration (Stage 1) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Add unit tests for search_images functionality: - Add TestSearchImages class to test_image_service.py for service layer - Add TestImageRepositorySearch class for repository layer with DB tests - Test pagination, filtering, ordering, and empty results Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>

Add SearchImagesAction for batch loading images with BatchQuerier: - Add ImageListResult type for search results - Add search_images method to ImageDBSource and ImageRepository - Add SearchImagesAction with BatchQuerier support - Register search_images processor in ImageProcessors Part of BEP-1039: Image ID Based Service Logic Migration (Stage 1) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Add image DataLoader for batch loading images by IDs: - Add ImageConditions and ImageOrders classes for query building - Add load_images_by_ids DataLoader function - Register image_loader in DataLoaders class Part of BEP-1039: Image ID Based Service Logic Migration (Stage 1) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

- Add test for empty ids returning empty list - Add test for returning images in request order - Add test for returning None for missing ids Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Copilot

Pull request overview

This PR implements the infrastructure for adding an aliases field to the ImageV2 GraphQL type using the DataLoader pattern to prevent N+1 query problems. However, the actual GraphQL field resolver is missing, which makes the feature non-functional.

Changes:

Added action types, repository methods, service handlers, and DataLoader infrastructure for fetching image aliases by batch
Refactored existing image loader to use ImageID type consistently
Added comprehensive unit tests for the new dataloader functionality

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
src/ai/backend/manager/services/image/actions/get_aliases_by_image_ids.py	Defines new action types for batch-fetching aliases (has type inconsistencies)
src/ai/backend/manager/repositories/image/db_source/db_source.py	Implements database query for fetching aliases by image IDs
src/ai/backend/manager/repositories/image/repository.py	Adds repository method with resilience decorator
src/ai/backend/manager/services/image/service.py	Adds service handler for the action and deprecation comment
src/ai/backend/manager/services/image/processors.py	Registers the new processor
src/ai/backend/manager/api/gql/data_loader/image/aliases_loader.py	Implements DataLoader function for batch loading aliases
src/ai/backend/manager/api/gql/data_loader/image/loader.py	Refactors to use ImageID consistently
src/ai/backend/manager/api/gql/data_loader/image/init.py	Exports new loader function
src/ai/backend/manager/api/gql/data_loader/data_loaders.py	Adds image_aliases_loader property
src/ai/backend/manager/repositories/image/options.py	Adds unrelated ordering methods
tests/unit/manager/api/image/test_dataloader.py	Comprehensive tests for both loaders
changes/8400.feature.md	Changelog entry

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-02T08:13:14Z

src/ai/backend/manager/services/image/actions/get_aliases_by_image_ids.py

+
+@dataclass
+class GetAliasesByImageIdsActionResult(BaseActionResult):
+    aliases_map: dict[UUID, list[str]]


The aliases_map return type should use ImageID instead of UUID for the dictionary keys to be consistent with other action results and with the dataloader usage. The load_aliases_by_image_ids function expects ImageID types, and other similar actions like GetImageInstalledAgentsActionResult use Mapping[ImageID, ...] for consistency.

src/ai/backend/manager/repositories/image/options.py

Copilot · 2026-02-02T08:13:14Z

src/ai/backend/manager/api/gql/data_loader/image/aliases_loader.py

+    if not image_ids:
+        return []
+
+    action = GetAliasesByImageIdsAction(image_ids=list(image_ids))


Type mismatch: the image_ids parameter is typed as Sequence[ImageID], but line 28 passes list(image_ids) to GetAliasesByImageIdsAction which expects list[UUID]. While ImageID is a NewType of UUID and this works at runtime, it may cause type checking issues.

This would be resolved if GetAliasesByImageIdsAction.image_ids uses list[ImageID] instead of list[UUID] (see the comment on that action class).

Copilot · 2026-02-02T08:13:15Z

src/ai/backend/manager/services/image/actions/get_aliases_by_image_ids.py

+
+from dataclasses import dataclass
+from typing import override
+from uuid import UUID


If the type is changed to use ImageID (as suggested in the comments above), you'll need to add an import: from ai.backend.common.types import ImageID (similar to how other image action files like get_image_installed_agents.py, preload_image.py, and unload_image.py do it).

Copilot · 2026-02-02T08:13:15Z

src/ai/backend/manager/api/gql/data_loader/image/aliases_loader.py

+async def load_aliases_by_image_ids(
+    processor: ImageProcessors,
+    image_ids: Sequence[ImageID],
+) -> list[list[str]]:
+    """Batch load image aliases by image IDs.
+
+    Args:
+        processor: ImageProcessors instance.
+        image_ids: List of image IDs to load aliases for.
+
+    Returns:
+        List of alias lists in the same order as image_ids.
+    """
+    if not image_ids:
+        return []
+
+    action = GetAliasesByImageIdsAction(image_ids=list(image_ids))
+    result = await processor.get_aliases_by_image_ids.wait_for_complete(action)
+
+    return [result.aliases_map.get(image_id, []) for image_id in image_ids]


This dataloader is implemented but the corresponding aliases field resolver is missing from the ImageV2GQL type definition. The entire purpose of this PR (BA-4131) is to add an aliases field to ImageV2GQL, but that field was never added. Without the field resolver in ImageV2GQL, this dataloader will never be called and the aliases feature will not work.

You need to add a field resolver method to the ImageV2GQL class (in src/ai/backend/manager/api/gql/image/types.py) that uses the image_aliases_loader to fetch aliases.

\Can't we just apply the ids filter in the search operation? I don't understand why the GetAliasesByimageIdsAction is necessary. It appears that SearchAliasesAction can be unified.

Copilot · 2026-02-02T08:13:15Z

src/ai/backend/manager/services/image/actions/get_aliases_by_image_ids.py

+
+@dataclass
+class GetAliasesByImageIdsAction(ImageAction):
+    image_ids: list[UUID]


The image_ids parameter should use ImageID type instead of UUID for consistency with other image actions in the codebase. Looking at similar actions like GetImageInstalledAgentsAction, PreloadImageAction, and UnloadImageAction (in the same directory), they all use list[ImageID] instead of list[UUID].

While UUID and ImageID are technically compatible (ImageID is a NewType of UUID), using ImageID provides better type safety and consistency across the action layer.

src/ai/backend/manager/repositories/image/repository.py

HyeockJinKim · 2026-02-03T04:18:18Z

src/ai/backend/manager/api/gql/data_loader/image/aliases_loader.py

+async def load_aliases_by_image_ids(
+    processor: ImageProcessors,
+    image_ids: Sequence[ImageID],
+) -> list[list[str]]:
+    """Batch load image aliases by image IDs.
+
+    Args:
+        processor: ImageProcessors instance.
+        image_ids: List of image IDs to load aliases for.
+
+    Returns:
+        List of alias lists in the same order as image_ids.
+    """
+    if not image_ids:
+        return []
+
+    action = GetAliasesByImageIdsAction(image_ids=list(image_ids))
+    result = await processor.get_aliases_by_image_ids.wait_for_complete(action)
+
+    return [result.aliases_map.get(image_id, []) for image_id in image_ids]


\Can't we just apply the ids filter in the search operation? I don't understand why the GetAliasesByimageIdsAction is necessary. It appears that SearchAliasesAction can be unified.

src/ai/backend/manager/repositories/image/db_source/db_source.py

src/ai/backend/manager/services/image/actions/search_aliases.py

github-actions bot assigned jopemachine Jan 28, 2026

github-actions bot added size:L 100~500 LoC comp:manager Related to Manager component labels Jan 28, 2026

jopemachine changed the title ~~feat: Add aliases field as dynamic resolver to ImageV2GQL~~ feat(BA-4131): Add aliases field as dynamic resolver to ImageV2GQL (WIP) Jan 28, 2026

jopemachine marked this pull request as draft January 28, 2026 05:47

jopemachine added this to the 26.2 milestone Jan 28, 2026

jopemachine force-pushed the BA-4037 branch 3 times, most recently from aa869ed to c2adf29 Compare January 29, 2026 06:07

jopemachine force-pushed the BA-4131 branch from d3a557d to 049e73c Compare January 29, 2026 06:22

github-actions bot added the area:docs Documentations label Jan 29, 2026

jopemachine changed the title ~~feat(BA-4131): Add aliases field as dynamic resolver to ImageV2GQL (WIP)~~ feat(BA-4131): Add aliases field as dynamic resolver to ImageV2 Jan 29, 2026

jopemachine marked this pull request as ready for review January 29, 2026 06:36

jopemachine force-pushed the BA-4037 branch from 94ecf40 to 19d31d5 Compare January 29, 2026 07:51

HyeockJinKim requested changes Jan 29, 2026

View reviewed changes

jopemachine marked this pull request as draft January 29, 2026 09:55

jopemachine and others added 13 commits January 30, 2026 07:18

test: Update

7dd209a

feat(BA-4099): Implement Image strawberry GraphQL DataLoaders (#8340)

b7a31f9

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>

fix: Use ImageData instead ofImageDataWithDetails

84665ed

test(BA-1039): Add tests for image GraphQL DataLoader

8bf6c41

- Add test for empty ids returning empty list - Add test for returning images in request order - Add test for returning None for missing ids Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

feat: Add New Actions

0a7925a

wip

ce4b87c

wip

fb7f016

fix: Revert search_images.py to base branch state

52ebbbf

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

wip

bb845fa

jopemachine force-pushed the BA-4037 branch 3 times, most recently from 0d29856 to 008c489 Compare February 2, 2026 03:43

Base automatically changed from BA-4037 to main February 2, 2026 07:03

jopemachine added 2 commits February 2, 2026 16:54

Merge origin/main into BA-4131

c97e89a

misc: Merge

994bcea

jopemachine marked this pull request as ready for review February 2, 2026 08:06

jopemachine requested review from HyeockJinKim and Copilot February 2, 2026 08:06

Copilot started reviewing on behalf of jopemachine February 2, 2026 08:06 View session

jopemachine requested a review from seedspirit February 2, 2026 08:06

misc: Revert wrong comment

e20da4c

Copilot AI reviewed Feb 2, 2026

View reviewed changes

seedspirit reviewed Feb 2, 2026

View reviewed changes

src/ai/backend/manager/repositories/image/repository.py Outdated Show resolved Hide resolved

fix: Use ImageID

e4de6c1

jopemachine requested a review from seedspirit February 2, 2026 08:50

fix: Use ImageID

a34647f

HyeockJinKim requested changes Feb 3, 2026

View reviewed changes

refactor: GetAliasesByImageIdsAction -> SearchAliasesAction

79c6697

jopemachine requested a review from HyeockJinKim February 3, 2026 04:34

jopemachine added 3 commits February 3, 2026 04:42

test: Update outdated tests

b33574f

feat: Add ImageAliasNode, Connection

4924f27

feat: Add aliases to ImageNodeV2

7cd6304

github-actions bot added size:XL 500~ LoC and removed size:L 100~500 LoC labels Feb 3, 2026

jopemachine changed the title ~~feat(BA-4131): Add aliases field as dynamic resolver to ImageV2~~ feat(BA-4131): Add ImageAlias support to Strawberry GraphQL schema Feb 3, 2026

jopemachine added 4 commits February 3, 2026 05:08

fix: Use ImageID

07e6cf7

fix: Use ImageID

6614acd

feat: Add missing pagination arguments

35ef335

feat: Add image_alias query base on id

6d26ae9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(BA-4131): Add `ImageAlias` support to Strawberry GraphQL schema #8400

feat(BA-4131): Add `ImageAlias` support to Strawberry GraphQL schema #8400

jopemachine commented Jan 28, 2026 •

edited by github-actions bot

Loading

Uh oh!

jopemachine commented Jan 29, 2026

Uh oh!

HyeockJinKim left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 2, 2026

Uh oh!

Uh oh!

Copilot AI Feb 2, 2026

Uh oh!

Copilot AI Feb 2, 2026

Uh oh!

Copilot AI Feb 2, 2026

Uh oh!

HyeockJinKim Feb 3, 2026

Uh oh!

Copilot AI Feb 2, 2026

Uh oh!

Uh oh!

HyeockJinKim Feb 3, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat(BA-4131): Add ImageAlias support to Strawberry GraphQL schema #8400

Are you sure you want to change the base?

feat(BA-4131): Add ImageAlias support to Strawberry GraphQL schema #8400

Conversation

jopemachine commented Jan 28, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Test plan

Related

Uh oh!

jopemachine commented Jan 29, 2026

Uh oh!

HyeockJinKim left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

HyeockJinKim Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

HyeockJinKim Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat(BA-4131): Add `ImageAlias` support to Strawberry GraphQL schema #8400

feat(BA-4131): Add `ImageAlias` support to Strawberry GraphQL schema #8400

jopemachine commented Jan 28, 2026 •

edited by github-actions bot

Loading