fix: Keep sync_container_lifecycles() bgtask alive in a loop.#2178
Merged
fix: Keep sync_container_lifecycles() bgtask alive in a loop.#2178
sync_container_lifecycles() bgtask alive in a loop.#2178Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
resource sync APIdepends on this PR?TL; DR
sync_containers_lifecycle()should workDetail
We have 3 different sources of Kernel / Container data
kernel_registryI tried to synchronize ALL Agent's data to Manager's DB but synchronizing actual containers to
kernel_registryor manager's data needs to process container destruction tasks which take a long time.Since
sync_containers_lifecycle()task synchronizes actual containers tokernel_registryperiodically in background, resource-sync API only needs to synckernel_registryto Manager side DB if it is ensured that the background task stays alive and works as we expect.Changes
Fix
sync_container_lifecycles()bgtask alive in a loop by handling any exceptions raised in the task.Enhance
sync_container_lifecycles()Checklist: (if applicable)