feat: Modify to have only one RaftNode per each physical node
#2108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account in order to use the merge queue. Sign up using this link. |
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
3 tasks
jopemachine
force-pushed
the
topic/05-03-feat_modify_to_have_only_one_raftnode_per_each_physical_node
branch
from
24402ad to
9056406
Compare
jopemachine
force-pushed
the
topic/05-03-feat_introduce_raftify_and_raftglobaltimer_to_replace_distributedglobaltimer
branch
2 times, most recently
from
fbe8733 to
e5705e7
Compare
jopemachine
force-pushed
the
topic/05-03-feat_modify_to_have_only_one_raftnode_per_each_physical_node
branch
from
9056406 to
d5cc888
Compare
This was referenced May 5, 2024
jopemachine
added
the
skip:changelog
kyujin-cho
force-pushed
the
topic/05-03-feat_introduce_raftify_and_raftglobaltimer_to_replace_distributedglobaltimer
branch
from
e5705e7 to
b9b8a24
Compare
kyujin-cho
force-pushed
the
topic/05-03-feat_modify_to_have_only_one_raftnode_per_each_physical_node
branch
from
d5cc888 to
036b9db
Compare
jopemachine
force-pushed
the
topic/05-03-feat_introduce_raftify_and_raftglobaltimer_to_replace_distributedglobaltimer
branch
from
1fec8fa to
a585601
Compare
jopemachine
force-pushed
the
topic/05-03-feat_modify_to_have_only_one_raftnode_per_each_physical_node
branch
from
036b9db to
778517c
Compare
jopemachine
force-pushed
the
topic/05-03-feat_modify_to_have_only_one_raftnode_per_each_physical_node
branch
from
778517c to
ebb0113
Compare
Yaminyam
deleted the
topic/05-03-feat_modify_to_have_only_one_raftnode_per_each_physical_node
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the existing multi-node, multi-process design in the Raftify integration PR (#2105).
Specifically, it modifies the design from creating num-proc RaftNodes per physical node to having only one RaftNode per physical node.
Checklist: (if applicable)