Skip to content

driver: introduce txchunk argument for console drivers#1824

Merged
Emantor merged 1 commit intolabgrid-project:masterfrom
N3xp7im3:txchunk
Mar 18, 2026
Merged

driver: introduce txchunk argument for console drivers#1824
Emantor merged 1 commit intolabgrid-project:masterfrom
N3xp7im3:txchunk

Conversation

@N3xp7im3
Copy link
Copy Markdown

@N3xp7im3 N3xp7im3 commented Feb 24, 2026

The txdelay argument only applies to single bytes. Sending those packets over the Internet causes additional per packet overhead, as each packet only contains a single byte payload.

Introduce an argument to group bytes into chunks, such that the txdelay applies to the chunk. This will reduce the overhead of packets send over the internet and better utilizes hardware FIFO's on the receiver side.

The default chunk size is 1 byte.

Copy link
Copy Markdown
Contributor

@a3f a3f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think you should update CHANGES.rst.

Comment thread doc/configuration.rst Outdated
Comment thread doc/configuration.rst Outdated
Comment thread doc/configuration.rst Outdated
Comment thread labgrid/driver/consoleexpectmixin.py Outdated
jluebbe
jluebbe previously approved these changes Feb 24, 2026
Comment thread labgrid/driver/consoleexpectmixin.py Outdated
Comment thread labgrid/driver/consoleexpectmixin.py Outdated
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.7%. Comparing base (1064f73) to head (5eb9316).
⚠️ Report is 4 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1824   +/-   ##
======================================
  Coverage    46.7%   46.7%           
======================================
  Files         179     179           
  Lines       14192   14202   +10     
======================================
+ Hits         6629    6645   +16     
+ Misses       7563    7557    -6     
Flag Coverage Δ
3.10 46.7% <100.0%> (+<0.1%) ⬆️
3.11 46.7% <100.0%> (+<0.1%) ⬆️
3.12 46.7% <100.0%> (+<0.1%) ⬆️
3.13 46.7% <100.0%> (+<0.1%) ⬆️
3.14 46.7% <100.0%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread labgrid/driver/consoleexpectmixin.py Outdated
@N3xp7im3 N3xp7im3 force-pushed the txchunk branch 2 times, most recently from 037773b to c9f9d75 Compare February 24, 2026 13:13
Emantor
Emantor previously approved these changes Feb 27, 2026
@Emantor
Copy link
Copy Markdown
Member

Emantor commented Feb 27, 2026

@N3xp7im3 there seems to be a documentation test failure, please take a look.

The txdelay argument only applies to single bytes.
Sending those packets over the Internet causes additional per packet
overhead, as each packet only contains a single byte payload.

Introduce an argument to group bytes into chunks, such that the txdelay
applies to the chunk. This will reduce the overhead of packets send over
the internet and better utilizes hardware FIFO's on the receiver side.

The default chunk size is 1 byte.

Signed-off-by: Fabian Pfitzner <f.pfitzner@pengutronix.de>
@Emantor Emantor merged commit bfb6ff2 into labgrid-project:master Mar 18, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants