Skip to content

Conversation

@steelman
Copy link

@steelman steelman commented Dec 8, 2025

Pass "dropins" variable to a template being rendered containing a list of *.yaml files in a directory named after the template being rendered with ".d" appended. For example when rendering /etc/labgrid/configuration.yaml a list of files matching /etc/labgrid/configuration.yaml.d/*.yaml will be available. Then configuration.yaml may be as simple as

{% for f in dropins %}
{% include f %}
{% endfor %}

And adding a target is possible by simply creating a file in /etc/labgrid/configuration.yaml.d directory.

@steelman steelman force-pushed the config-dorp-ins branch 2 times, most recently from c53b3ef to 4bb5a11 Compare December 8, 2025 16:16
@jluebbe
Copy link
Member

jluebbe commented Dec 9, 2025

Force-pushed to fix a ruff error.

@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.1%. Comparing base (0c01c19) to head (ae26c5d).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
labgrid/remote/config.py 0.0% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1785     +/-   ##
========================================
- Coverage    45.1%   45.1%   -0.1%     
========================================
  Files         172     172             
  Lines       13608   13612      +4     
========================================
  Hits         6144    6144             
- Misses       7464    7468      +4     
Flag Coverage Δ
3.10 45.1% <0.0%> (-0.1%) ⬇️
3.11 45.1% <0.0%> (-0.1%) ⬇️
3.12 45.1% <0.0%> (-0.1%) ⬇️
3.13 45.1% <0.0%> (-0.1%) ⬇️
3.14 45.1% <0.0%> (-0.1%) ⬇️
3.9 45.1% <0.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Pass "drop_ins" variable to a template being rendered containing a list of
*.yaml files in a directory named after the template being rendered with
".d" appended. For example when rendering /etc/labgrid/configuration.yaml
a list of files matching /etc/labgrid/configuration.yaml.d/*.yaml will be
available. Then configuration.yaml may be as simple as

{% for f in drop_ins %}
{% include f %}
{% endfor %}

And adding a target is possible by simply creating a file in
/etc/labgrid/configuration.yaml.d directory.

Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
@jluebbe
Copy link
Member

jluebbe commented Dec 9, 2025

Force-pushed to fix sphinx syntax.

@jluebbe
Copy link
Member

jluebbe commented Dec 9, 2025

@steelman Do you still consider this RFC? Otherwise, please remove the marker from the title, so that we can get it merged.

@steelman steelman changed the title [RFC] remote/config: support drop-in files remote/config: support drop-in files Dec 9, 2025
@steelman
Copy link
Author

steelman commented Dec 9, 2025

If you're fine, I am fine. Do you think this could/should be tested somehow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants