Shelldriver: make destination authorized keys file an arguement#1732
Open
pmelange wants to merge 2 commits intolabgrid-project:masterfrom
Open
Shelldriver: make destination authorized keys file an arguement#1732pmelange wants to merge 2 commits intolabgrid-project:masterfrom
pmelange wants to merge 2 commits intolabgrid-project:masterfrom
Conversation
pmelange
force-pushed
the
25.0.1-shelldriver_authorized_keys_file
branch
6 times, most recently
from
75a5828 to
b56722e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1732 +/- ##
======================================
Coverage 45.8% 45.8%
======================================
Files 182 182
Lines 14718 14722 +4
======================================
+ Hits 6743 6745 +2
- Misses 7975 7977 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Emantor
requested changes
Dec 17, 2025
Add an addition optional arg "dest_authorized_keys" with the default value of ```~/.ssh/authorized_keys```, An example where this might be used is when an embedded system uses dropbear as it's ssh server daemon. In such a case, the authorized_keys file is ```/etc/dropbear/authorized_keys``` Additionally, the ```put_key_file``` takes an optional ```dest_authorized_keys``` function parameter which defaults to the above arg. Fixes: #labgrid-project#1626 Signed-off-by: Perry Melange <isprotejesvalkata@gmail.com>
Move the documentation comment from _put_ssh_key to put_ssh_key along with adding documentation for the aguements. Documention needful of reworking introduced in 2c62fd6 Signed-off-by: Perry Melange <isprotejesvalkata@gmail.com>
pmelange
force-pushed
the
25.0.1-shelldriver_authorized_keys_file
branch
from
bb9f08d to
3f2ab9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change the ShellDriver so that the authorized_keys file can be set to something other than
~/.ssh. This is necessary if the DUT is running dropbear, where the authorized_keys file is located (on OpenWrt) in/etc/dropbear/authorized_keys.The default value for the new arguement is
~/.sshand therefore any old code should not need to be updated. In addition, the call to put_ssh_key() has a new optional arg where the user can set the destination authorized_keys file. This could also be useful for setting up a multi-user system and to put the authorized_keys file for each user in their own home directory.Checklist
Fixes: #1626