Conversation
PlaylistIterator now accepts a parameter to load track metadata (artist data only*). idomaarReader caches this data if it is loaded, so it doesn't have to be loaded on each new instance. Also fixed some bugs ref. to the load of session data.
Before this commit the model wouldn't actually use the metadata.
the iterator now works without hard-coding dataset values or schema. It is less efficient as it now uses dictionaries instead of vectors whether they are better or not. However, this allows one to not to worry about dataset quirks when parsing metadata. The iterator also has a new registry that servers as a lookup table for existing entities, so if a session has some song it just keeps the reference of the existing entity. This also allows metadata to be preloaded into songs and artists. An important change is that all elements are constructed and persisted in cascade, even if you do not use them (users, for example). It might be a good idea to keep a blacklist or whitelist of entity types to save later. For now it's enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PlaylistIterator now accepts a parameter to load track metadata (artist
data only*). idomaarReader caches this data if it is loaded, so
it doesn't have to be loaded on each new instance.
Also fixed some bugs ref. to the loading of session data.
dataset, so we decided against using it.