feat: updated to latest version of specifications#135
Closed
feat: updated to latest version of specifications#135
Conversation
mvantellingen
approved these changes
Feb 3, 2026
Author
|
Depending of how long it takes until commercetools/rmf-codegen#334 is merged, we can wait and do it properly. |
Author
|
Can be done via #136 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation: Commercetools added a file attributes-filtering.raml which uses filter[attributes] as a query-parameter. This is not supported in the current version of rmf-codegen and generates non-compiling go code.
I worked around this by adding a replacement as post-process step in the Taskfile.yaml. For the future this should be fixed within rmf-codegen. I already created an issue -> commercetools/rmf-codegen#333