Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to make dependency vulnerability search more robust by normalizing the search query parameter so leading/trailing whitespace doesn’t affect query matching.
Changes:
- Added
stringsimport to support search normalization. - Trimmed the
searchquery parameter before passing it to repository paging methods inDependencyVulnController.ListPaged.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
151
to
153
| shared.GetPageInfo(ctx), | ||
| ctx.QueryParam("search"), | ||
| strings.Trim(ctx.QueryParam("search"), " "), | ||
| shared.GetFilterQuery(ctx), |
There was a problem hiding this comment.
The trimmed search expression is duplicated in both branches (flat and non-flat). Consider reading search := strings.TrimSpace(ctx.QueryParam("search")) once before the if, and reusing it. Also, this controller’s other list endpoints still pass the raw ctx.QueryParam("search"), which makes search behavior inconsistent across routes.
timbastin
approved these changes
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Trim to search query so trailing and leading whitespaces won't mess with the search
Issue: #1783