Prevent vexrule modal from flashing when clicking redirection link#696
Open
Prevent vexrule modal from flashing when clicking redirection link#696
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent the VEX rule details modal from briefly opening (“flashing”) when a user clicks the CVE ID link that navigates to the dependency risks page.
Changes:
- Stops click event propagation on the CVE ID
<Link>inside the VEX rules table cell to avoid triggering the row’s click handler.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
67
to
69
| <Link | ||
| onClick={(event)=>{event.stopPropagation()}} | ||
| href={`/${params.organizationSlug}/projects/${params.projectSlug}/assets/${params.assetSlug}/refs/${params.assetVersionSlug}/dependency-risks?search=${encodeURIComponent(cveId)}&state=closed`} |
There was a problem hiding this comment.
Formatting here doesn’t match the repo’s Prettier-enforced style (e.g., missing spaces around => and unnecessary block). This will likely fail prettier/prettier linting—please format like other stopPropagation handlers in the codebase (e.g., onClick={(e) => e.stopPropagation()}).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue:l3montree-dev/devguard#1759