implemented proper url formatting in settingsinput fields#695
Open
implemented proper url formatting in settingsinput fields#695
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to improve URL display/formatting in InputWithButton fields (notably for long public URLs), addressing overflow by enabling consumer-provided input styling (e.g., truncation).
Changes:
- Add spacing between the input and action buttons (
gap-1) inInputWithButton. - Forward
classNamefromInputWithButtonprops into the underlying<input>. - Apply
className="truncate"to public URL inputs in the asset vuln management section.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/components/ui/input-with-button.tsx |
Adjusts layout spacing and attempts to merge consumer className into the input styling. |
src/components/asset/asset-form/AssetFormVulnsManagement.tsx |
Uses the newly-forwarded className to truncate long public URL values. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: l3montree-dev/devguard#1795