WIP: Use proper JSON in textarea #37
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value of the text area will be stored in database. When the pain(t) question loads, it will populate the text area with an initial value. That textarea value does not need to have back- slashes extra escaped as opposed to the string that is assigned as a JavaScript variable. This usally has no implications: ILIAS only sends the textarea value if an answer has changed and an answer only changes if some- one has edited the canvas and therefore the logic has already updated the textarea with "normal" (i.e. not double-escaped) JSON it was initialized with. Now, if you install a certain patch provided by databay AG that restores the feature that answers are saved during question list navigation at all, the patch will store the question's answer, no matter if the answer has changed after loading from DB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of the text area will be stored in database. When the pain(t) question loads, it will populate the text area with an initial value. That textarea value does not need to have back- slashes extra escaped as opposed to the string that is assigned as a JavaScript variable.
This usually has no implications: ILIAS only sends the textarea value if an answer has changed and an answer only changes if some- one has edited the canvas and therefore the logic has already updated the textarea with "normal" (i.e. not double-escaped) JSON it was initialized with.
Now, if you install a certain patch provided by databay AG that restores the feature that answers are saved during question list navigation at all, the patch will store the question's answer, no matter if the answer has changed after loading from DB.
I guess you can remove the whitespace changes, if you'd like to, yourself. Editor is told to remove trailing whitespace for compliance with other projects.