Use JSON data when altering the page order#337
Open
PLUS-RobertEhrenleitner wants to merge 3 commits intokylephillips:masterfrom
Open
Use JSON data when altering the page order#337PLUS-RobertEhrenleitner wants to merge 3 commits intokylephillips:masterfrom
PLUS-RobertEhrenleitner wants to merge 3 commits intokylephillips:masterfrom
Conversation
|
Would love to see this merged, anything to speed up the performance when dealing with large numbers of pages! |
Contributor
Author
|
@drewbaker Did you comment to the wrong PR? This PR does not speed up anything. It just fixes an issue when moving a too large subtree. The speed up can be achieved by PR 335, also submitted by me. |
Contributor
Author
|
I have updated the patch because I am afraid it had not worked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue when there are more than 1000 pages to move, since this is the limit of query parameters most servers can handle. The list of pages is collapsed into a single field, which is represented as JSON data, rather than as an array.