Misc improvements or fixes #251
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bf64cf2, reversing changes made to f022103. This change isn't right -- it an LDAP setup when `group_attribute_is_dn on` is enabled, which is what this section of code (kvspb@bf64cf2#diff-c05c0daefb48996cbf510b81002b49bcR2230) is conditionally targeting. This original PR kvspb#199 changed the underlying LDAP query (eg `user_val`) from looking up the user's DN as a group attribute in LDAP (eg set via the `group_attribute` directive in nginx) to looking up the _group's_ DN, which isn't right and won't work. This PR reverts the previous change to make this work correctly again. Fwiw, the originally-referenced issue kvspb#180 seems to be a completely different issue, relating to escaping and parentheses.
…on) or chain (verify cert chain but not hostname/IP)
…l_handshake_handler with ssl_check_cert and ssl_ca_dir
PR: kvspb#237 from mmguero-dev
- Add possibility to retrieve LDAP attributes during LDAP search
…ishement - Replaces list of 'search_attribute XXX' parameter by 'search_attributes XXX [YYY [ ... ]]' - Support additional/optional 'encoding' param for 'binddn_passwd' parameter
- Fixes support of Nginx 1.23.0
- Add clean_on_timeout parameter - Improve debug traces when multiple connections are used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kvspb project seems to have not accepted pull-requests since a long time, but creating this pull request from my own fork may provide some visibility on my fork for people looking for some new features or fixes.