-
Notifications
You must be signed in to change notification settings - Fork 17
Pre-release #765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-release #765
Conversation
feat: nodejs24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "browser": "./dist/kuzzle.js", | ||
| "main": "./out/index.js", | ||
| "types": "index.d.ts", | ||
| "exports": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Type entry points to missing declaration file
package.json now advertises TypeScript definitions at "types": "index.d.ts" (and exports uses the same path), but tsconfig now emits declarations under out/ (outDir set in tsconfig.json line 5) and there is no index.d.ts at the repository root (find . -name index.d.ts returns nothing). Any TypeScript consumer resolving this package will look for a non-existent root declaration and get “cannot find module … or its corresponding type declarations”, so typings are broken for all builds from this commit.
Useful? React with 👍 / 👎.
|
🎉 This PR is included in version 7.16.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 7.16.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Overview
Multiple things have been implemented for a pretty long PR.
Important things are