This repository was archived by the owner on Mar 6, 2020. It is now read-only.
Prom metrics#49
Open
01100010011001010110010101110000 wants to merge 5 commits intokurrent-io:masterfrom
Open
Conversation
Author
|
@ameier38 would appreciate a review, whenever you have some spare time |
ameier38
suggested changes
Nov 16, 2019
Contributor
ameier38
left a comment
ameier38
left a comment
There was a problem hiding this comment.
Thanks for PR. This would be a great addition. Could you also add the new options to the README?
ameier38
suggested changes
Dec 5, 2019
Contributor
ameier38
left a comment
ameier38
left a comment
There was a problem hiding this comment.
This is great, just one more request. Would prefer to keep the image values consistent throughout the chart. See comments.
|
Hi @ameier38, I'd like to ping on this PR as it's been some time since your last review. I'm asking because our team is currently running Eventstore on kubernetes and would appreciate it, if monitoring was part of the package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What this PR does / why we need it:
It is common for k8s services to export metrics in the prometheus format. This PR enables EventStore to do that by adding this prometheus exporter as a sidecar in the
StatefulSet