Changed default cluster size back to 3

[GoatCodeNL]

Signed-off-by: Niels van Esch nvanesch@saa.nl

PR Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• Chart Version bumped
• Chart packaged and index updated (you can use ./release)
• CHANGELOG.md updated

What this PR does / why we need it:
This PR restores the default clustersize to 3. to make it consistent with documentation, with other default values and expected behaviour.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #36

Special notes for your reviewer:

[riccardone]

I don't have permission to merge. This PR need to be merged

[ameier38]

We had changed the default cluster size back to 1 so the port forwarding worked out of the box. My mistake to not update the docs. Could we just update the docs to have the default value as 1?

[riccardone]

can you please do that in a new PR and then we can eventually ask to close this one

[GoatCodeNL]

Ofcourse I can change it. However I disagree that this would be the better default.

• 3 is more like production
• 1 conflicts with current pdb default. This defaults to minAvailable of 2. It will never reach this. This means rolling updates get stuck and terminating instances do an unclean shutdown.
• Portforwards are a debug situation.

Honstly I would rather make a pr for you to add a note to the portforward docs.

But I leave that up to you. Please let me know your preferred solution and I’ll make the PR.

[ameier38]

I agree that 3 is more like production, but also think that @hnicke raised a good point here that the chart should work out of the box with port-forwarding so it is easy to get started.

What if we added a values-production.yml similar to the postgres chart and added clusterSize: 3 there?

[GoatCodeNL]

I'll see if I can create the PR somewhere this week. I'll create a PR with:

• updated documents
• changed PDB (defaulting to maxunavailable 1 in stead of minavailable 2
• values-production.yaml
• production advisory doc