fix: harden crew dispatch profile enforcement

[kunchenguid]

Intent

Harden dispatch-profile consultation so config/crew-dispatch.json cannot be silently bypassed. Bootstrap should print a concise active-rules block for valid crew-dispatch configs while preserving the invalid JSON/schema error path. fm-spawn should require an explicit resolved harness for crewmate and scout dispatches whenever that file exists, while preserving no-file fallback to config/crew-harness, preserving explicit --harness, positional harness, raw launch command, and batch behavior, and exempting --secondmate launches. Update AGENTS.md and focused behavior tests for those contracts.

What Changed

• Captain, surfaces valid config/crew-dispatch.json rules during bootstrap while keeping malformed or invalid config diagnostics intact.
• Requires crewmate and scout spawns to pass an explicit resolved harness whenever dispatch profiles are present, while preserving explicit harness, positional harness, raw launch command, batch, fallback, and secondmate behavior.
• Updates firstmate docs and focused shell tests around dispatch-profile enforcement and bootstrap reporting.

Risk Assessment

✅ Low: Captain, the change is narrowly scoped to bootstrap reporting and spawn-time harness enforcement, and I found no material correctness or compatibility issues in the reviewed paths.

Testing

Captain, the configured full-suite baseline was already green per prompt; I reran the focused bootstrap and spawn dispatch-profile behavior tests, then captured CLI evidence showing the intended end-user contracts working in isolated homes with fake tmux and real git worktrees. All focused checks and manual evidence-producing scenarios passed.

Evidence: Manual CLI evidence transcript

## Bootstrap surfaces active dispatch rules
$ FM_HOME=$BOOT_HOME FM_ROOT_OVERRIDE=$BOOT_HOME bin/fm-bootstrap.sh
CREW_DISPATCH: active config/crew-dispatch.json
  rule: fresh news -> grok
  rule: big feature -> codex/gpt-5.5/high
  default: claude/haiku/low

## Bootstrap preserves malformed JSON error path
$ FM_HOME=$BOOT_HOME FM_ROOT_OVERRIDE=$BOOT_HOME bin/fm-bootstrap.sh
CREW_DISPATCH: invalid config/crew-dispatch.json - malformed JSON

## fm-spawn refuses crewmate spawn when dispatch profile is active and no harness was passed
$ bin/fm-spawn.sh evidence-ship-z1 <project>
exit=1
error: config/crew-dispatch.json is active - pass an explicit harness resolved from the dispatch rules (the consultation backstop, so the rules are never silently skipped).
meta exists? no

## fm-spawn accepts explicit resolved harness and records launch details
$ bin/fm-spawn.sh evidence-explicit-z2 <project> --harness codex --model gpt-5 --effort high
exit=0
spawned evidence-explicit-z2 harness=codex kind=ship mode=no-mistakes yolo=off window=firstmate:fm-evidence-explicit-z2 worktree=/var/folders/5x/4nqprlbx0518k3ybcb1sz6gr0000gn/T/no-mistakes-evidence/01KWBNS83NX0YWR86G0RNFPEYP/manual-cli/worktree
harness=codex
kind=ship
model=gpt-5
effort=high
captured launch command:
codex --model 'gpt-5' -c 'model_reasoning_effort="high"' --dangerously-bypass-approvals-and-sandbox -c "notify=[\"bash\",\"-c\",\"touch '/private/var/folders/5x/4nqprlbx0518k3ybcb1sz6gr0000gn/T/no-mistakes-evidence/01KWBNS83NX0YWR86G0RNFPEYP/manual-cli/spawn-home/state/evidence-explicit-z2.turn-ended'\"]" "$(cat '/var/folders/5x/4nqprlbx0518k3ybcb1sz6gr0000gn/T/no-mistakes-evidence/01KWBNS83NX0YWR86G0RNFPEYP/manual-cli/spawn-home/data/evidence-explicit-z2/brief.md')"

## fm-spawn preserves no-profile fallback to config/crew-harness
$ rm config/crew-dispatch.json; bin/fm-spawn.sh evidence-fallback-z3 <project>
exit=0
spawned evidence-fallback-z3 harness=codex kind=ship mode=no-mistakes yolo=off window=firstmate:fm-evidence-fallback-z3 worktree=/var/folders/5x/4nqprlbx0518k3ybcb1sz6gr0000gn/T/no-mistakes-evidence/01KWBNS83NX0YWR86G0RNFPEYP/manual-cli/worktree
harness=codex
kind=ship
model=default
effort=default

## fm-spawn exempts secondmate launches from the crewmate dispatch backstop
$ bin/fm-spawn.sh evidence-secondmate-z4 <secondmate-home> --secondmate
exit=0
warning: secondmate evidence-secondmate-z4 sync skipped before launch: primary default-branch commit cannot be resolved
spawned evidence-secondmate-z4 harness=codex kind=secondmate mode=secondmate yolo=off window=firstmate:fm-evidence-secondmate-z4 worktree=/private/var/folders/5x/4nqprlbx0518k3ybcb1sz6gr0000gn/T/no-mistakes-evidence/01KWBNS83NX0YWR86G0RNFPEYP/manual-cli/secondmate-home
harness=codex
kind=secondmate
model=default
effort=default
home=/private/var/folders/5x/4nqprlbx0518k3ybcb1sz6gr0000gn/T/no-mistakes-evidence/01KWBNS83NX0YWR86G0RNFPEYP/manual-cli/secondmate-home
captured launch command:
FM_ROOT_OVERRIDE= FM_STATE_OVERRIDE= FM_DATA_OVERRIDE= FM_PROJECTS_OVERRIDE= FM_CONFIG_OVERRIDE= FM_HOME='/private/var/folders/5x/4nqprlbx0518k3ybcb1sz6gr0000gn/T/no-mistakes-evidence/01KWBNS83NX0YWR86G0RNFPEYP/manual-cli/secondmate-home' codex --dangerously-bypass-approvals-and-sandbox "$(cat '/private/var/folders/5x/4nqprlbx0518k3ybcb1sz6gr0000gn/T/no-mistakes-evidence/01KWBNS83NX0YWR86G0RNFPEYP/manual-cli/secondmate-home/data/charter.md')"

Evidence: Focused bootstrap behavior test log

ok - bootstrap reports treehouse lease + tasks-axi default/backend contracts
ok - bootstrap enforces no-mistakes minimum version
ok - bootstrap surfaces active crew-dispatch rules and default
ok - bootstrap validates crew-dispatch.json and reports malformed or unverified configs

Evidence: Focused spawn dispatch-profile behavior test log

ok - no --model/--effort records defaults and keeps the claude launch byte-identical
ok - active crew-dispatch profile requires an explicit harness for ship spawns
ok - active crew-dispatch profile requires an explicit harness for scout spawns
ok - active crew-dispatch profile allows an explicit resolved harness
ok - active crew-dispatch profile allows the legacy positional harness form
ok - active crew-dispatch profile allows the raw launch-command escape hatch
ok - claude receives --model and --effort profile flags
ok - codex receives --model and model_reasoning_effort profile flags
ok - codex omits unsupported max effort instead of passing a bad config value
ok - grok receives --model and --reasoning-effort profile flags
ok - grok omits unsupported max reasoning effort
ok - opencode receives --model and omits the unsupported effort axis
ok - pi threads model and omits unsupported max effort
ok - batch dispatch forwards shared --harness, --model, and --effort to every pair
ok - active crew-dispatch profile does not block secondmate launches
# all fm-spawn-dispatch-profile tests passed

Pipeline

Updates from git push no-mistakes

✅ **intent** - passed

✅ No issues found.

✅ **Rebase** - passed

✅ No issues found.

✅ **Review** - passed

✅ No issues found.

✅ **Test** - passed

✅ No issues found.

• command -v tmux >/dev/null || { echo "tmux is required for e2e tests" >&2; exit 1; }; tmux -V; rc=0; for t in tests/*.test.sh; do echo "== $t =="; bash "$t" || rc=1; done; exit "$rc"
• Baseline already successful per prompt: command -v tmux >/dev/null || { echo "tmux is required for e2e tests" >&2; exit 1; }; tmux -V; rc=0; for t in tests/*.test.sh; do echo "== $t =="; bash "$t" || rc=1; done; exit "$rc"
• bash tests/fm-bootstrap.test.sh > /var/folders/5x/4nqprlbx0518k3ybcb1sz6gr0000gn/T/no-mistakes-evidence/01KWBNS83NX0YWR86G0RNFPEYP/fm-bootstrap-test.log 2>&1
• bash tests/fm-spawn-dispatch-profile.test.sh > /var/folders/5x/4nqprlbx0518k3ybcb1sz6gr0000gn/T/no-mistakes-evidence/01KWBNS83NX0YWR86G0RNFPEYP/fm-spawn-dispatch-profile-test.log 2>&1
• Manual isolated CLI verification saved to dispatch-profile-cli-transcript.txt: fm-bootstrap.sh valid active rules, malformed JSON error path, fm-spawn.sh no-harness refusal with no meta, explicit codex spawn with captured launch command, no-profile config/crew-harness fallback, and --secondmate exemption.

✅ **Document** - passed

✅ No issues found.

✅ **Lint** - passed

✅ No issues found.

✅ **Push** - passed

✅ No issues found.