fix(brief): remove lone apostrophe that broke fm-brief.sh parse#140
Open
thatguyintech wants to merge 1 commit into
Open
fix(brief): remove lone apostrophe that broke fm-brief.sh parse#140thatguyintech wants to merge 1 commit into
thatguyintech wants to merge 1 commit into
Conversation
A lone apostrophe in 'no-mistakes' own guidance' inside the no-mistakes DOD=$(cat <<EOF ... EOF) command substitution made bash treat it as an unterminated single quote, failing the whole file to parse and aborting every scaffold path. Reword to drop the apostrophe.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bin/fm-brief.shfailed to parse, aborting every brief-scaffold path (ship no-mistakes / direct-PR / local-only,--scout, and--secondmate).Root cause
Line 211 had a lone apostrophe —
Follow no-mistakes' own guidance— inside the no-mistakesDOD=$(cat <<EOF ... EOF)command substitution. Bash's command-substitution scanner respects quote characters even inside the heredoc body, so it treated that'as the start of an unterminated single-quoted string and the whole file failed to parse. Regression from #102.Fix
Reword to
Follow the no-mistakes guidance for the mechanics:, removing the lone apostrophe while keeping the contract's meaning intact.Verification
bash -n bin/fm-brief.sh→ exit 0; allbin/*.shparse.--scout,--secondmate) with throwaway ids; generated no-mistakes Definition-of-done reads correctly.DOD=$(cat <<EOF ... EOF)blocks and the plain heredocs; no other quote could regress the same way.