feat(cognee): add manual memory lookup helper#130
Open
JTInventory wants to merge 9 commits into
Open
Conversation
Adopt upstream baseline and active watcher fix
feat: adopt deterministic route resolver
* feat(cognee): add local lookup manifest checker * feat(cognee): verify local source hints
ecf0bf7 to
b6794df
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Firstmate can now run an optional manual Cognee memory lookup before dispatch without making Cognee part of the authority chain. The helper prints untrusted memory hints separately from opened local source paths and warnings, and
--append-briefwrites only opened source paths or a non-blocking unavailable note into a brief.Safety Boundaries
FM_COGNEE_LOOKUP_CMDexits 0 withmemory unavailable, so dispatch can continue without memory context.Validation
bash -n bin/fm-memory-lookup.sh tests/fm-memory-lookup.test.shtests/fm-memory-lookup.test.shset -e; for t in tests/*.test.sh; do "$t"; donegit diff --checkplus no-index whitespace checks for the two new executable filesshellcheck bin/fm-memory-lookup.sh tests/fm-memory-lookup.test.shwas not run becauseshellcheckis not installed in this environmentce-code-reviewwas not run because this session's multi-agent tool policy only allows subagent spawning when explicitly requestedPost-Deploy Monitoring & Validation
No additional production monitoring is required because this is an inert manual CLI helper. Validate on first real use by confirming an unavailable backend prints
memory unavailableand exits 0, a configured read-only backend keepsmemory hint,verified local source path, andwarningseparate, and any brief attachment contains only opened local source paths plus advisory wording. Treat any raw Cognee answer in a brief, automatic dispatch query, Gbrain invocation, or nonzero unavailable-backend exit as a rollback trigger.