Ropes/boolean field #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP Adding boolean values to CommandDefintion configuration examples and tests. Signed-off-by: Josh Roppo <josh@kubos.co>
Tests were picking up the import cycle between Gateway<->satellite packages. Over-separated functionality into separate packages. WIP Signed-off-by: Josh Roppo <josh@kubos.co>
The `show_hidden` field is now accepted on the "update_file_list" command. When True, the files returned will include 'hidden' files using the unix `.filename` syntax. Signed-off-by: Josh Roppo <josh@kubos.co>
Code which has value to use as base for further functionality resides in the `gateway` package. The `satellite` package only contains demonstration functionality of what a satellite might provide. Signed-off-by: Josh Roppo <josh@kubos.co>
Signed-off-by: Josh Roppo <josh@kubos.co>
Enables testing the Radio-boolean fields with other options. Signed-off-by: Josh Roppo <josh@kubos.co>
Ropes
force-pushed
the
ropes/boolean-field
branch
from
6d2c11f to
3bf6185
Compare
Contributor
Subsystem Power is typical ON/OFF. So you might have something like a |
Contributor
|
I'd like to split out the boolean-related changes from the rest and hold onto those until the backend is upgraded and deployed. The rest looks good and can be merged immediately (if it's finished). |
miketwo
suggested changes
Oct 23, 2021
Contributor
miketwo
left a comment
miketwo
left a comment
There was a problem hiding this comment.
We can probably close this now, yeah?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple Changes
majortom-gatewaylibrary versionFunctional Changes
tests/satellite/test_sat,pytotests/test_sat.py. This makes some testing libraries happier.Note: I have additional example commands for testing boolean types that I haven't committed. Can anyone think of nice satellite commands that would benefit having a boolean field?