Skip to content

chore: moves workflow crd helper structs to this repo#123

Merged
anoop2811 merged 4 commits intokubevela:mainfrom
semmet95:chore/crd-struct-centralization
Oct 15, 2025
Merged

chore: moves workflow crd helper structs to this repo#123
anoop2811 merged 4 commits intokubevela:mainfrom
semmet95:chore/crd-struct-centralization

Conversation

@semmet95
Copy link
Contributor

@semmet95 semmet95 commented Oct 3, 2025

Changes

  • adds shared Workflow CRD structs
  • adds github workflow and makefile commands to ensure artifacts are updated to keep up with the changes

Summary by cubic

Centralizes workflow CRD helper structs under apis/oam/v1alpha1 and removes the kubevela/workflow dependency. Workflow types are now self-contained, simplifying maintenance and code generation.

  • Refactors

    • Added local structs: InputItem, OutputItem, StepInputs/Outputs, WorkflowStepMeta, WorkflowStepBase, WorkflowStep, WorkflowSpec, WorkflowMode, WorkflowExecuteMode.
    • Updated Workflow to use local types and inline WorkflowSpec.
    • Regenerated deepcopy methods for new types.
  • Dependencies

    • Removed github.com/kubevela/workflow v0.6.2 from go.mod/go.sum.

@codecov
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.64%. Comparing base (a91fd1f) to head (36bda23).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
- Coverage   86.71%   86.64%   -0.08%     
==========================================
  Files          82       82              
  Lines        4072     4072              
==========================================
- Hits         3531     3528       -3     
- Misses        408      410       +2     
- Partials      133      134       +1     
Flag Coverage Δ
unit-test 86.64% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@semmet95 semmet95 marked this pull request as ready for review October 3, 2025 11:56
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Signed-off-by: Amit Singh <singhamitch@outlook.com>
@semmet95 semmet95 force-pushed the chore/crd-struct-centralization branch from b1d0924 to e34ac02 Compare October 11, 2025 03:48
Signed-off-by: Amit Singh <singhamitch@outlook.com>
Signed-off-by: Amit Singh <singhamitch@outlook.com>
@semmet95 semmet95 force-pushed the chore/crd-struct-centralization branch from eb0ad59 to 2a192b7 Compare October 11, 2025 05:07
Signed-off-by: Amit Singh <singhamitch@outlook.com>
@semmet95 semmet95 force-pushed the chore/crd-struct-centralization branch from 0368da3 to 36bda23 Compare October 11, 2025 08:58
@anoop2811 anoop2811 merged commit 14cd204 into kubevela:main Oct 15, 2025
10 checks passed
@semmet95 semmet95 deleted the chore/crd-struct-centralization branch October 16, 2025 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants