feat: adds common workflow crd struct#120
Merged
anoop2811 merged 2 commits intokubevela:mainfrom Sep 24, 2025
Merged
Conversation
Signed-off-by: Amit Singh <singhamitch@outlook.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
==========================================
- Coverage 86.78% 86.64% -0.15%
==========================================
Files 82 82
Lines 4071 4072 +1
==========================================
- Hits 3533 3528 -5
- Misses 406 410 +4
- Partials 132 134 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
1 issue found across 8 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="crds/core.oam.dev_workflows.yaml">
<violation number="1" location="crds/core.oam.dev_workflows.yaml:41">
Custom fields are defined at the top level instead of under .spec, deviating from Kubernetes API conventions and risking tooling/user confusion.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
e08bd96 to
2d6e83c
Compare
briankane
approved these changes
Sep 23, 2025
Signed-off-by: Amit Singh <singhamitch@outlook.com>
2d6e83c to
39870b0
Compare
anoop2811
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Adds a shared Workflow CRD and Go type (core.oam.dev/v1alpha1) moved from Workflow repo for a consistent workflow definition. Includes the CRD manifest and generated deepcopy code.
Fixes: #122
New Features
Dependencies