Skip to content

feat: adds common workflow crd struct#120

Merged
anoop2811 merged 2 commits intokubevela:mainfrom
semmet95:feature/common-crd-types
Sep 24, 2025
Merged

feat: adds common workflow crd struct#120
anoop2811 merged 2 commits intokubevela:mainfrom
semmet95:feature/common-crd-types

Conversation

@semmet95
Copy link
Contributor

@semmet95 semmet95 commented Sep 23, 2025

Summary by cubic

Adds a shared Workflow CRD and Go type (core.oam.dev/v1alpha1) moved from Workflow repo for a consistent workflow definition. Includes the CRD manifest and generated deepcopy code.

Fixes: #122

  • New Features

    • New Workflow type in apis/oam/v1alpha1.
    • Added CRD manifest: crds/core.oam.dev_workflows.yaml (namespaced, kind: Workflow).
    • Regenerated deepcopy and updated CRD annotations to controller-gen v0.16.5.
  • Dependencies

    • Added github.com/kubevela/workflow v0.6.2.
    • Bumped apiserver-runtime and mergo versions.

Signed-off-by: Amit Singh <singhamitch@outlook.com>
@codecov
Copy link

codecov bot commented Sep 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.64%. Comparing base (a2894a6) to head (39870b0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
- Coverage   86.78%   86.64%   -0.15%     
==========================================
  Files          82       82              
  Lines        4071     4072       +1     
==========================================
- Hits         3533     3528       -5     
- Misses        406      410       +4     
- Partials      132      134       +2     
Flag Coverage Δ
unit-test 86.64% <100.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@semmet95 semmet95 marked this pull request as ready for review September 23, 2025 06:31
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 8 files

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name="crds/core.oam.dev_workflows.yaml">

<violation number="1" location="crds/core.oam.dev_workflows.yaml:41">
Custom fields are defined at the top level instead of under .spec, deviating from Kubernetes API conventions and risking tooling/user confusion.</violation>
</file>

React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.

@semmet95 semmet95 force-pushed the feature/common-crd-types branch from e08bd96 to 2d6e83c Compare September 23, 2025 06:46
Signed-off-by: Amit Singh <singhamitch@outlook.com>
@semmet95 semmet95 force-pushed the feature/common-crd-types branch from 2d6e83c to 39870b0 Compare September 24, 2025 14:36
@anoop2811 anoop2811 merged commit 528095b into kubevela:main Sep 24, 2025
7 of 8 checks passed
@semmet95 semmet95 deleted the feature/common-crd-types branch September 25, 2025 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move workflow struct from workflow repo to pkg

3 participants