Skip to content

fix(cli): prevent uninstall timeout by deleting CRDs before controller #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1012Charan wants to merge 1 commit into
base: master
Choose a base branch
from
+31 −1
Open

fix(cli): prevent uninstall timeout by deleting CRDs before controller #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 31 additions & 1 deletion pkg/internal/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,13 @@ func UninstallKubeSliceController(ApplicationConfiguration *ConfigurationSpecs)
util.Printf("\nUninstalling KubeSlice Controller...")
cc := ApplicationConfiguration.Configuration.ClusterConfiguration
time.Sleep(200 * time.Millisecond)

// First delete CRDs to trigger worker uninstallation
util.Printf("Deleting KubeSlice CRDs to trigger worker cleanup...")
deleteKubeSliceCRDs(cc.ControllerCluster)
time.Sleep(2 * time.Second) // Give time for workers to be cleaned up

// Then uninstall the controller
uninstallKubeSliceController(cc.ControllerCluster)
time.Sleep(200 * time.Millisecond)
util.Printf("%s Successfully uninstalled KubeSlice Controller", util.Tick)
Expand Down Expand Up @@ -78,9 +85,32 @@ func installKubeSliceController(cluster Cluster, hc HelmChartConfiguration) {

func uninstallKubeSliceController(cluster Cluster) {
args := make([]string, 0)
args = append(args, "--kube-context", cluster.ContextName, "--kubeconfig", cluster.KubeConfigPath, "uninstall", KUBESLICE_CONTROLLER_NAMESPACE, "--namespace", KUBESLICE_CONTROLLER_NAMESPACE)
args = append(args, "--kube-context", cluster.ContextName, "--kubeconfig", cluster.KubeConfigPath, "uninstall", KUBESLICE_CONTROLLER_NAMESPACE, "--namespace", KUBESLICE_CONTROLLER_NAMESPACE, "--timeout", "2m")
err := util.RunCommand("helm", args...)
if err != nil {
log.Fatalf("Process failed %v", err)
}
}

func deleteKubeSliceCRDs(cluster Cluster) {
// List of KubeSlice CRDs to delete
crdNames := []string{
"projects.controller.kubeslice.io",
"clusters.controller.kubeslice.io",
"sliceconfigs.controller.kubeslice.io",
"serviceexportconfigs.controller.kubeslice.io",
"serviceexports.networking.kubeslice.io",
}

for _, crdName := range crdNames {
args := make([]string, 0)
args = append(args, "--kube-context", cluster.ContextName, "--kubeconfig", cluster.KubeConfigPath, "delete", "crd", crdName)
err := util.RunCommand("kubectl", args...)
if err != nil {
// Log error but continue with other CRDs
util.Printf("%s Warning: Failed to delete CRD %s: %v", util.Cross, crdName, err)
} else {
util.Printf("%s Deleted CRD: %s", util.Tick, crdName)
}
}
}