test(): add unit tests for common.go (0% ➝ 100% coverage) #74
Open
yuvraj-kolkar17 wants to merge 9 commits intokubeslice:masterfrom
Open
test(): add unit tests for common.go (0% ➝ 100% coverage) #74yuvraj-kolkar17 wants to merge 9 commits intokubeslice:masterfrom
yuvraj-kolkar17 wants to merge 9 commits intokubeslice:masterfrom
Conversation
Signed-off-by: yuvraj Kolkar <kolkaryuvraj2@gmail.com>
Signed-off-by: yuvraj Kolkar <144676738+yuvraj-kolkar17@users.noreply.github.com>
Signed-off-by: yuvraj Kolkar <144676738+yuvraj-kolkar17@users.noreply.github.com>
Signed-off-by: yuvraj Kolkar <144676738+yuvraj-kolkar17@users.noreply.github.com>
Signed-off-by: yuvraj Kolkar <144676738+yuvraj-kolkar17@users.noreply.github.com>
Author
|
Hi @priyank-upadhyay @narmidm @gourishkb @Rahul-D78 Can you please review this PR ! |
Author
Contributor
|
Hello @yuvraj-kolkar17
Thanks ! |
Author
ok i will do that @Alokzh |
…-kolkar17/kubeslice-cli into test/add-cmd-common-tests
Author
|
@Alokzh PTAL |
Contributor
|
Thnx @yuvraj-kolkar17 |
Signed-off-by: yuvraj Kolkar <kolkaryuvraj2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added comprehensive unit tests for the
cmd/common.gofile to achieve 100% test coverage.This ensures the core utility functions in the
common.gofile behave as expected across various edge cases.Part of #46
How Has This Been Tested?
go test ./cmd -coverprofile=coverage.out go tool cover -func=coverage.outBefore vs After:
Checklist:
Does this PR introduce a breaking change?