Skip to content

[occm] Include cloudConfigContents in DaemonSet checksum annotation#3080

Open
234u34k wants to merge 1 commit intokubernetes:masterfrom
234u34k:fix/occm-checksum-cloudconfigcontents
Open

[occm] Include cloudConfigContents in DaemonSet checksum annotation#3080
234u34k wants to merge 1 commit intokubernetes:masterfrom
234u34k:fix/occm-checksum-cloudconfigcontents

Conversation

@234u34k
Copy link

@234u34k 234u34k commented Mar 1, 2026

The DaemonSet checksum annotation only hashes the output of the cloudConfig template helper. When cloud config is supplied via cloudConfigContents, changes to it do not trigger pod restarts. Credential rotations and endpoint changes go undetected.

Include cloudConfigContents in the checksum input.

Ref #3030

occm: Fix DaemonSet checksum annotation to include cloudConfigContents so that config changes trigger pod restarts.

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 1, 2026
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 1, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: 234u34k / name: 234u34k (6c98256)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign stephenfin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from dulek and stephenfin March 1, 2026 16:49
@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 1, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @234u34k. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 1, 2026
When cloud config is supplied via cloudConfigContents rather than the
structured cloudConfig values, changes to it do not alter the checksum
annotation on the DaemonSet pod template. Pods are not restarted after
credential rotation or endpoint changes.
@234u34k 234u34k force-pushed the fix/occm-checksum-cloudconfigcontents branch from c1a5df2 to 6c98256 Compare March 1, 2026 18:36
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants