[occm] Include cloudConfigContents in DaemonSet checksum annotation#3080
[occm] Include cloudConfigContents in DaemonSet checksum annotation#3080234u34k wants to merge 1 commit intokubernetes:masterfrom
Conversation
|
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @234u34k. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
When cloud config is supplied via cloudConfigContents rather than the structured cloudConfig values, changes to it do not alter the checksum annotation on the DaemonSet pod template. Pods are not restarted after credential rotation or endpoint changes.
c1a5df2 to
6c98256
Compare
The DaemonSet checksum annotation only hashes the output of the
cloudConfigtemplate helper. When cloud config is supplied viacloudConfigContents, changes to it do not trigger pod restarts. Credential rotations and endpoint changes go undetected.Include
cloudConfigContentsin the checksum input.Ref #3030