Skip to content

Conversation

@stephenfin
Copy link
Member

What this PR does / why we need it:

Per $subject.

Which issue this PR fixes(if applicable):
(none)

Special notes for reviewers:

This should pass CI. In particular, it should pass the manila job.

Release note:

NONE

Simply:

    go get -u github.com/gophercloud/gophercloud/v2@v2.8.0
    go mod tidy

Followed by some fixes to a test (my fault: I didn't consider our test
framework part of the public API when I made and backported that change
/o\).

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Co-authored-by: Jesse Haka <haka.jesse@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 7, 2025
@k8s-ci-robot k8s-ci-robot requested review from dulek and kayrus October 7, 2025 12:02
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 7, 2025
@stephenfin
Copy link
Member Author

/test openstack-cloud-csi-manila-e2e-test

@stephenfin
Copy link
Member Author

/assign zetaab
/assign mandre

Copy link
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2025
@stephenfin
Copy link
Member Author

/assign kayrus

Copy link
Member

@zetaab zetaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lhtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2025
@zetaab
Copy link
Member

zetaab commented Oct 8, 2025

ops typo

/lgtm

@kayrus
Copy link
Contributor

kayrus commented Oct 8, 2025

why it's still not merged?

@k8s-ci-robot k8s-ci-robot merged commit 6840634 into kubernetes:master Oct 8, 2025
6 checks passed
@stephenfin stephenfin deleted the gophercloud-bump-v28 branch October 8, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants