-
Notifications
You must be signed in to change notification settings - Fork 649
[all] Bump gophercloud to v2.8.0 #3006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[all] Bump gophercloud to v2.8.0 #3006
Conversation
Simply:
go get -u github.com/gophercloud/gophercloud/v2@v2.8.0
go mod tidy
Followed by some fixes to a test (my fault: I didn't consider our test
framework part of the public API when I made and backported that change
/o\).
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Co-authored-by: Jesse Haka <haka.jesse@gmail.com>
|
/test openstack-cloud-csi-manila-e2e-test |
|
/assign zetaab |
mandre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/assign kayrus |
zetaab
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lhtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zetaab The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
ops typo /lgtm |
|
why it's still not merged? |
What this PR does / why we need it:
Per $subject.
Which issue this PR fixes(if applicable):
(none)
Special notes for reviewers:
This should pass CI. In particular, it should pass the manila job.
Release note: