Replace self-referenced links with relative paths#167
Replace self-referenced links with relative paths#167ali-a-a wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
k8s-ci-robot
added
the
kind/documentation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ali-a-a The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for node-readiness-controller ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @ali-a-a. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
size/S
|
/ok-to-test /cc @ajaysundark |
k8s-ci-robot
added
ok-to-test
| This example uses **Calico**, but the pattern applies to any CNI. | ||
|
|
||
| > **Note**: You can find all the manifests used in this guide in the [`examples/cni-readiness`](https://github.com/kubernetes-sigs/node-readiness-controller/tree/main/examples/cni-readiness) directory. | ||
| > **Note**: You can find all the manifests used in this guide in the [`examples/cni-readiness`](../../../../examples/cni-readiness) directory. |
There was a problem hiding this comment.
I dont think this works as how you expect it to be. AFAICT, the netlify will know only the 'docs/book/src' universe, so any parent directory ('../') look up above will still refer to the root, so this will eventually self-reference this page than the code-directory (examples/cni-readiness) you're looking to link here.
you can check the deploy preview here: https://deploy-preview-167--node-readiness-controller.netlify.app/ (you can find this at the PR).
I think the goal of this PR could be to only replace relative-links for "doc pages" not the code-references.
There was a problem hiding this comment.
Thanks for the review. I think we don't have any links to doc pages that are not relative then. We might want to just close this PR. The CI error we faced in this PR will happen again though.
There was a problem hiding this comment.
Thanks for taking a look. can we convert this to a doc PR to add a suggestion to use relative paths while x-ref other pages in docs/README.md then?
3 participants
Description
This PR replaces GitHub links that are pointing to this repo with a relative path.
Related Issue
Fixes #166
Type of Change
/kind documentation
Testing
This PR has no code changes.
Checklist
make testpassesmake lintpassesDoes this PR introduce a user-facing change?