Skip to content

Conversation

@tmurakam
Copy link
Contributor

@tmurakam tmurakam commented Oct 17, 2025

What type of PR is this?
/kind feature

What this PR does / why we need it:
Update etcd from 3.5.x to 3.6.6

See also #12629

Which issue(s) this PR fixes:
Fixes #12629

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update etcd to 3.6.6

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 17, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tmurakam
Once this PR has been reviewed and has the lgtm label, please assign tico88612 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 17, 2025
@tmurakam
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 17, 2025
@tmurakam tmurakam marked this pull request as ready for review October 17, 2025 08:47
@tmurakam
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2025
@tmurakam tmurakam force-pushed the feature/kubernetes-1.34-etcd-3.6 branch from 230570c to 322a58b Compare October 17, 2025 09:25
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 17, 2025
@tmurakam tmurakam force-pushed the feature/kubernetes-1.34-etcd-3.6 branch from 322a58b to 57122c3 Compare October 17, 2025 11:24
@tmurakam tmurakam changed the title [WIP] Update etcd to 3.6 for Kubernetes 1.34 Update etcd to 3.6 for Kubernetes 1.34 Oct 20, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 20, 2025
@tmurakam
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2025
@tico88612
Copy link
Member

tico88612 commented Oct 23, 2025

@tmurakam Do you think we need to be aware of this? Upgrade to 3.5.24 first?
https://etcd.io/blog/2025/upgrade_from_3.5_to_3.6_issue_followup/

@tmurakam
Copy link
Contributor Author

tmurakam commented Oct 23, 2025

@tico88612
It recommended to upgrade 3.5.24, but there is a workaround restarting etcd (3.5.20-3.5.23) before upgrading.
I already put a restart task before upgrading, so it is not mandatory.

EDIT: Note: The etcd version of the Kubespray 2.29.0 is 3.5.23.

@tmurakam tmurakam force-pushed the feature/kubernetes-1.34-etcd-3.6 branch from 57122c3 to 7d8e797 Compare October 23, 2025 23:54
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 23, 2025
@tmurakam tmurakam force-pushed the feature/kubernetes-1.34-etcd-3.6 branch from 7d8e797 to ed51a39 Compare October 23, 2025 23:57
@tmurakam
Copy link
Contributor Author

@tico88612
I believe all corrections have been made. Would you please review it?

@tico88612
Copy link
Member

/cc

Copy link
Member

@tico88612 tico88612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

Comment on lines +2 to +5
- name: Debug etcd_current_version
ansible.builtin.debug:
msg: "{{ etcd_current_version }}"
when: etcd_cluster_setup
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we need this debug message?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not mandatory.
But this is the last chance to show the etcd version before installing a new one, so this might be useful for troubleshooting.

@VannTen
Copy link
Contributor

VannTen commented Nov 14, 2025

IMO, I'd first do a simple upgrade to 3.5.24 for one release, backport it to 2.29 (and previous branch as well) to be a little extra careful.

Not sure if we should delay the upgrade to 3.6 until after 2.30 though 🤔

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 14, 2025
@tmurakam tmurakam force-pushed the feature/kubernetes-1.34-etcd-3.6 branch from 8b5746d to aceeabc Compare November 15, 2025 06:49
@k8s-ci-robot k8s-ci-robot added do-not-merge/contains-merge-commits size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 15, 2025
@tmurakam tmurakam force-pushed the feature/kubernetes-1.34-etcd-3.6 branch from f528f20 to 5997631 Compare November 15, 2025 06:57
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/contains-merge-commits size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 15, 2025
@tmurakam tmurakam force-pushed the feature/kubernetes-1.34-etcd-3.6 branch 3 times, most recently from d1aac94 to 2723b97 Compare November 18, 2025 13:00
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 18, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 18, 2025
@tmurakam tmurakam force-pushed the feature/kubernetes-1.34-etcd-3.6 branch from 2723b97 to ea58fe4 Compare November 18, 2025 13:02
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 18, 2025
@tmurakam
Copy link
Contributor Author

/retest

@tmurakam tmurakam force-pushed the feature/kubernetes-1.34-etcd-3.6 branch from ea58fe4 to c478640 Compare December 1, 2025 00:38
when:
- etcd_current_version is version('3.5.20', '<')
fail:
msg: "You need to upgrade etcd to 3.5.20 or later before upgrade to 3.6. Current version is {{ etcd_current_version }}."
Copy link
Contributor

@VannTen VannTen Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think now that release-2.29 has etcd 3.5.25, we should make a patch release for 2.29 ASAP, and require etcd to be at least 3.5.24 for the upgrade. Once we have the release we can probably also mention the kubespray version to be extra helpful, IMO.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do this release cut in next week.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will change this version check to >=3.5.24

- Add hashes for etcd 3.6.6
- Remove etcd v2 backup task for etcd 3.6
  The etcd 3.6 removes 'etcdctl backup' command with ETCDCTL_API=2
- Downgrade etcd to 3.5 in netchecker
  The netchecker does not work with etcd 3.6 becaust it removes v2 API support (--enable-v2).
  And netchekcer does not support v3 API.
@tmurakam tmurakam force-pushed the feature/kubernetes-1.34-etcd-3.6 branch from c478640 to 8b753a1 Compare December 6, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade etcd to 3.6

4 participants