-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Update etcd to 3.6 for Kubernetes 1.34 #12634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update etcd to 3.6 for Kubernetes 1.34 #12634
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tmurakam The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
|
/hold |
230570c to
322a58b
Compare
322a58b to
57122c3
Compare
|
/unhold |
|
@tmurakam Do you think we need to be aware of this? Upgrade to 3.5.24 first? |
|
@tico88612 EDIT: Note: The etcd version of the Kubespray 2.29.0 is 3.5.23. |
57122c3 to
7d8e797
Compare
7d8e797 to
ed51a39
Compare
|
@tico88612 |
|
/cc |
tico88612
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments
| - name: Debug etcd_current_version | ||
| ansible.builtin.debug: | ||
| msg: "{{ etcd_current_version }}" | ||
| when: etcd_cluster_setup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we need this debug message?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not mandatory.
But this is the last chance to show the etcd version before installing a new one, so this might be useful for troubleshooting.
|
IMO, I'd first do a simple upgrade to 3.5.24 for one release, backport it to 2.29 (and previous branch as well) to be a little extra careful. Not sure if we should delay the upgrade to 3.6 until after 2.30 though 🤔 |
8b5746d to
aceeabc
Compare
f528f20 to
5997631
Compare
d1aac94 to
2723b97
Compare
2723b97 to
ea58fe4
Compare
|
/retest |
ea58fe4 to
c478640
Compare
roles/etcd/tasks/clean_v2_store.yml
Outdated
| when: | ||
| - etcd_current_version is version('3.5.20', '<') | ||
| fail: | ||
| msg: "You need to upgrade etcd to 3.5.20 or later before upgrade to 3.6. Current version is {{ etcd_current_version }}." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think now that release-2.29 has etcd 3.5.25, we should make a patch release for 2.29 ASAP, and require etcd to be at least 3.5.24 for the upgrade. Once we have the release we can probably also mention the kubespray version to be extra helpful, IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will do this release cut in next week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I will change this version check to >=3.5.24
- Add hashes for etcd 3.6.6 - Remove etcd v2 backup task for etcd 3.6 The etcd 3.6 removes 'etcdctl backup' command with ETCDCTL_API=2 - Downgrade etcd to 3.5 in netchecker The netchecker does not work with etcd 3.6 becaust it removes v2 API support (--enable-v2). And netchekcer does not support v3 API.
c478640 to
8b753a1
Compare
What type of PR is this?
/kind feature
What this PR does / why we need it:
Update etcd from 3.5.x to 3.6.6
See also #12629
Which issue(s) this PR fixes:
Fixes #12629
Special notes for your reviewer:
Does this PR introduce a user-facing change?: