Skip to content

Conversation

@jaeyung1001
Copy link
Contributor

@jaeyung1001 jaeyung1001 commented Sep 27, 2025

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add support for a global omitStages setting in the audit policy via audit_policy_global_omit_stages variable. It provides a simple way to exclude specific audit stages (e.g., ResponseStarted, Panic) across all rules, which was not previously possible in Kubespray.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add audit_policy_global_omit_stages variable to configure global omitStages in the audit policy.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 27, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jaeyung1001
Once this PR has been reviewed and has the lgtm label, please assign ant31 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 27, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @jaeyung1001. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 28, 2025
@jaeyung1001
Copy link
Contributor Author

Hi, @MrFreezeex @ErikJiang . Could you please review this PR? thank you :)

@ErikJiang
Copy link
Member

It's a nice convenience boost.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@jaeyung1001
Copy link
Contributor Author

It's a nice convenience boost.

/lgtm

Hi, @ErikJiang. I updated the code because of pre-commit failed. could you please check it again? thank you :)

@jaeyung1001
Copy link
Contributor Author

It's a nice convenience boost.
/lgtm

Hi, @ErikJiang. I updated the code because of pre-commit failed. could you please check it again? thank you :)

Hi, @ErikJiang. Just in case you missed the mention, please check it out when you free. thank you :)

@jaeyung1001
Copy link
Contributor Author

@ErikJiang I would appreciate it if you could review it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants