-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat(audit): add audit_policy_global_omit_stages variable to audit policy #12580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jaeyung1001 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @jaeyung1001. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
a4ea7f2 to
9bff118
Compare
|
Hi, @MrFreezeex @ErikJiang . Could you please review this PR? thank you :) |
|
It's a nice convenience boost. /lgtm |
9bff118 to
7b9da04
Compare
|
New changes are detected. LGTM label has been removed. |
Hi, @ErikJiang. I updated the code because of pre-commit failed. could you please check it again? thank you :) |
Hi, @ErikJiang. Just in case you missed the mention, please check it out when you free. thank you :) |
|
@ErikJiang I would appreciate it if you could review it again. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add support for a global omitStages setting in the audit policy via
audit_policy_global_omit_stagesvariable. It provides a simple way to exclude specific audit stages (e.g., ResponseStarted, Panic) across all rules, which was not previously possible in Kubespray.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: