generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 206
Implement PrepareDataPlugin for prefix cache match plugin #1942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rahulgurnani
wants to merge
13
commits into
kubernetes-sigs:main
Choose a base branch
from
rahulgurnani:pc-m
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
396490d
Add PrepareRequestData method for the prefix cache plugin
rahulgurnani 980fd29
Add prefix cache match scorer
rahulgurnani 53c92c1
Ensure prefix cache plugin implements all preprae data plugin methods
rahulgurnani fdb1125
Enable prepare data plugins behind a feature flag
rahulgurnani 46b5ac2
Add static check to ensure plugin implements PrepareDataPlugin interface
rahulgurnani 1f9e0cd
Rename prefix cache match
rahulgurnani b3765c7
Add feature gate for prepare data plugin
rahulgurnani a2c3da8
Update prefix cache match to have total and match length
rahulgurnani cb88bdb
Add more tests, register prefix cache scorer and address other review…
rahulgurnani 74cf6a5
Move prefix cache scorer out of this PR
rahulgurnani 35eafd9
Fix rebase errors
rahulgurnani d7b6a7e
Update directory structure
rahulgurnani 5ebc667
Update TODOs
rahulgurnani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| /* | ||
| Copyright 2025 The Kubernetes Authors. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package approximateprefix | ||
|
|
||
| import ( | ||
| "sigs.k8s.io/gateway-api-inference-extension/pkg/epp/datalayer" | ||
| ) | ||
|
|
||
| const ( | ||
| PrefixCacheMatchInfoKey = "PrefixCacheMatchInfoKey" | ||
| ) | ||
|
|
||
| type PrefixCacheMatchInfo struct { | ||
| matchLength int | ||
| totalBlocks int | ||
| } | ||
|
|
||
| func NewPrefixCacheMatchInfo(matchLen int, blockHashLen int) *PrefixCacheMatchInfo { | ||
| return &PrefixCacheMatchInfo{ | ||
| matchLength: matchLen, | ||
| totalBlocks: blockHashLen, | ||
| } | ||
| } | ||
|
|
||
| func (p *PrefixCacheMatchInfo) MatchLength() int { | ||
| return p.matchLength | ||
| } | ||
|
|
||
| func (p *PrefixCacheMatchInfo) TotalLength() int { | ||
| return p.totalBlocks | ||
| } | ||
|
|
||
| func (p *PrefixCacheMatchInfo) Clone() datalayer.Cloneable { | ||
| return &PrefixCacheMatchInfo{ | ||
| matchLength: p.matchLength, | ||
| totalBlocks: p.totalBlocks, | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -107,7 +107,11 @@ func (c *Config) AddPlugins(pluginObjects ...plugins.Plugin) { | |
|
|
||
| // PrepareDataPluginGraph creates data dependency graph and sorts the plugins in topological order. | ||
| // If a cycle is detected, it returns an error. | ||
| // TODO(#1970): Validate data dependency graph even when prepare data plugins are not in use. | ||
| func (c *Config) PrepareDataPluginGraph() error { | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we create an issue that we should create a dag, even when the prepare data plugins are not in use? we want to make sure that all data consumers have a corresponding consumer, and they are not cyclical. It's not scoped to just prepare data |
||
| if len(c.prepareDataPlugins) == 0 { | ||
| return nil | ||
| } | ||
| dag := buildDAG(c.prepareDataPlugins) | ||
| plugins, err := sortPlugins(dag, c.prepareDataPlugins) | ||
| if err != nil { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.