fix: uncordon nodes left cordoned after lock loss#1282
Open
xavierleune wants to merge 1 commit intokubereboot:mainfrom
Open
fix: uncordon nodes left cordoned after lock loss#1282xavierleune wants to merge 1 commit intokubereboot:mainfrom
xavierleune wants to merge 1 commit intokubereboot:mainfrom
Conversation
Signed-off-by: Xavier Leune <xavier.leune@gmail.com>
c693d58 to
a9e825c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--pre-reboot-node-labelsor--annotate-nodesmarkersProblem
When a node reboots and kured restarts, if
lock.Holding()returnsfalse(lock expired or released), the uncordon logic is skipped entirely. The node remains cordoned with pre-reboot labels but kured doesn't recognize it as "its own" node to uncordon.This is particularly problematic with MicroOS or similar auto-updating OS where a second reboot may be required immediately after the first.
Fixes #63
Solution
After checking
lock.Holding(), if we don't hold the lock, check if the node:KuredRebootInProgressAnnotation(if--annotate-nodesis enabled), OR--pre-reboot-node-labelslabelsIf either condition is true AND the node is unschedulable, uncordon it.