Set config-syncer CI license via LICENSE_KEY in unit-tests#498
Merged
Conversation
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
Inject the config-syncer license into charts/config-syncer/ci/ci-values.yaml from a LICENSE_KEY env var in Go TestMain (using yaml.v3) instead of a yq step, and pass LICENSE_KEY through the unit-tests make target. Drop the now-unneeded yq/kubectl host-prep step from the CI build job. Signed-off-by: Tamal Saha <tamal@appscode.com>
tamalsaha
force-pushed
the
config-syncer-license-key
branch
from
33eb53e to
8b396e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inject the config-syncer license into
charts/config-syncer/ci/ci-values.yamlfrom aLICENSE_KEYenv var in GoTestMain(usingsigs.k8s.io/yaml) instead of ayqstep, and passLICENSE_KEYthrough theunit-testsmake target. Drop the now-unneeded yq/kubectl host-prep step from the CI build job.Resolved conflicts against current
master:kmodules.xyz/image-packer(ed3c452e3c7f) over the version this change originally bumped to.sigs.k8s.io/yamlpromoted from indirect to direct.Verified locally:
go vet ./tests/...andgo mod verifypass.