Conversation
tamalsaha
force-pushed
the
fix
branch
6 times, most recently
from
d6dd934 to
ffb6f57
Compare
tamalsaha
changed the title
- Switch catalog to ghcr.io/appscode/config-syncer:v0.15.5-ent - Render config-syncer with a fake license during update-catalog.sh so its images are discovered, resetting the license afterwards - Bump image-packer to pick up per-chart ci/ci-values.yaml support - Drop the now-unneeded config-syncer entry from ignoreMissingList - Bump CI kubectl to v1.31.0 via dl.k8s.io Signed-off-by: Tamal Saha <tamal@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switch the catalog to the enterprise config-syncer image and make catalog image discovery work without requiring a real license.
Changes
catalog/imagelist.yaml: Useghcr.io/appscode/config-syncer:v0.15.5-ent.hack/scripts/update-catalog.sh: Temporarily set a fake license incharts/config-syncer/ci/ci-values.yamlso config-syncer templates render duringimage-packer list, then reset the license back afterwards (via anEXITtrap).kmodules.xyz/image-packer: Bump the dependency, and the vendoredpkg/lib/image.gonow passes a chart'sci/ci-values.yamlas--valueswhen present, so per-chart CI values feed image discovery.tests/check-charts_test.go: Drop the now-unneededignoreMissingListentry forconfig-syncersince its image is discovered correctly..github/workflows/ci.yml: Bump CI kubectl tov1.31.0viadl.k8s.io.