add oracle image pull secret#873
Draft
SajjadSadi074 wants to merge 6 commits into
Draft
Conversation
Signed-off-by: SajjadSadi074 <sajjadsadi2203@gmail.com>
Signed-off-by: SajjadSadi074 <sajjadsadi2203@gmail.com>
|
Visit the preview URL for this PR (updated for commit 93b5365): https://kubedb-v2-hugo--pr873-add-oracle-image-pul-zvihwkcx.web.app (expires Mon, 01 Jun 2026 07:25:16 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 0f29ae8ae0bd54a99bf2b223b6833be47acd5943 |
Signed-off-by: SajjadSadi074 <sajjadsadi2203@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the Oracle documentation to reflect pulling Oracle Database images from Oracle’s container registry by adding image pull secret guidance and wiring imagePullSecrets into the sample manifests.
Changes:
- Update the example Oracle image reference shown by
kubectl get oracleversionsto usecontainer-registry.oracle.com. - Add a new quickstart section describing how to create an Oracle registry pull secret.
- Add
imagePullSecretsto Oracle/DataGuard sample YAMLs in multiple Oracle docs pages.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| docs/guides/oracle/quickstart/guide.md | Updates the version output sample and adds instructions + YAML example for creating/using an Oracle registry pull secret. |
| docs/guides/oracle/failover/overview.md | Adds imagePullSecrets to DataGuard/observer sample pod templates. |
| docs/guides/oracle/concepts/oracle.md | Adds imagePullSecrets to the standalone and DataGuard sample specs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
109
to
113
| podTemplate: | ||
| imagePullSecrets: | ||
| - name: orclcred | ||
| spec: | ||
| serviceAccountName: oracle-sample |
Signed-off-by: SajjadSadi074 <sajjadsadi2203@gmail.com>
Signed-off-by: SajjadSadi074 <sajjadsadi2203@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.