[patch] Re-enable package validation with suppression files (ktsu.Sdk 2.13.2)#2
Merged
Merged
Conversation
Reverts the blunt EnablePackageValidation=false in favor of keeping validation ON. - Bumps global.json to ktsu.Sdk 2.13.2, which disables strict cross-TFM ApiCompat (EnableStrictModeForCompatibleFrameworksInPackage / ...CompatibleTfms) at the SDK layer while keeping EnablePackageValidation + baseline-strict validation on. - Removes the per-project EnablePackageValidation=false overrides (rely on SDK default). - Adds a regenerable CompatibilitySuppressions.xml per package (17 entries each) capturing the Polyfill framework-shim cross-TFM diffs ApiCompat reports as false positives (CP0014/CP0015/CP0016); regenerate with 'dotnet pack -p:ApiCompatGenerateSuppressionFile=true'. Baseline validation still catches real breaks vs a published version. Verified packages pack clean (0 CP errors) with validation enabled (via the equivalent settings). NU1510 did not reproduce, so no framework-reference conditioning was needed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores package validation (reverts the blunt
EnablePackageValidation=falsedisable) now thatktsu.Sdk 2.13.2relaxes the strict cross-TFM checks that were producing Polyfill false positives.Background
dotnet packwas failing ApiCompat withCP0014/CP0015/CP0016errors comparing per-TFM assemblies. Every flagged type is a Polyfill-embedded framework shim (DefaultInterpolatedStringHandler,ExperimentalAttribute,NullabilityInfo,DynamicallyAccessedMemberTypes, …) whose shape legitimately differs per TFM — false positives, not real API breaks.ktsu.Sdk 2.13.2(ktsu-dev/Sdk#16) disables the strict cross-TFM validation at the SDK layer while keeping baseline validation on.Changes
global.json→ktsu.Sdk 2.13.2(carriesEnableStrictModeForCompatibleFrameworksInPackage=false/EnableStrictModeForCompatibleTfms=false).EnablePackageValidation=falseoverrides across all 44 projects — validation is back on via the SDK default.CompatibilitySuppressions.xmlper package (43 files, 17 entries each) capturing the residual Polyfill shim diffs. Regenerate withdotnet pack -p:ApiCompatGenerateSuppressionFile=true.Result
EnableStrictModeForBaselineValidationstays on).ktsu.Sdk 2.13.2: packages pack clean (0 CP errors) with validation on.NU1510(framework-package pruning) did not reproduce, so noPackageReferenceconditioning was needed.