Fix Live Activity job scheduling with Cloud Tasks#316
Conversation
|
✅ PR 체크 스킵 ⚡ 빌드 대상 코드 변경이 없어 빌드/테스트를 건너뛰었습니다. 상세 정보
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the Live Activity job scheduling mechanism by replacing the existing polling worker with Google Cloud Tasks. This change aims to improve the efficiency and reliability of Live Activity updates by leveraging a managed task queue service. It introduces a new internal endpoint for task dispatch, updates configuration, and includes thorough testing to ensure the robustness of the new system. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request transitions the Live Activity job processing from an internal background worker to an external scheduling system using Google Cloud Tasks. It introduces a LiveActivityJobScheduler trait with a Cloud Tasks implementation, adds a new internal API endpoint for job dispatching with secret-based authentication, and updates the service layer to enqueue tasks upon job creation or update. Documentation and tests have been updated to reflect these architectural changes. I have no feedback to provide.
Summary
변경 유형
변경 파일
infra/rust-backend/src/services/live_activity_service.rsinfra/rust-backend/src/routes/internal.rs,routes/schedules.rs,routes/mod.rs.github/workflows/deploy-rust.yml,infra/rust-backend/.env.example,.ai/REST_API.mdinfra/rust-backend/tests/live_activity_test.rs스크린샷 (UI 변경 시)
N/A
Test plan
cargo test --manifest-path infra/rust-backend/Cargo.toml --test live_activity_test -- --test-threads=1cargo test --manifest-path infra/rust-backend/Cargo.toml --test schedules_testcargo test --manifest-path infra/rust-backend/Cargo.toml --test rust_migration_regression_test/health200, internal dispatch 401 without secret / 200processed:falsewith secretcargo test --manifest-path infra/rust-backend/Cargo.toml --testsblocked by existingmedia_upload_urls_testbase_path/basePathmismatch관련 이슈
N/A