Conversation
There was a problem hiding this comment.
This is not a helpful variable name.
|
Grade: 4.0 / 5 While your code is very clean and short, it could be a lot more readable. Use descriptive variable names so that other people (and you a few months later) can tell what is going on. So try to avoid 1 letter variable names as well as names like "temp". Code readability is VERY important, since most of the time you spend programming will be working with code that you didn't write yourself, not writing brand new code. Most of these functions are working with codons, not DNA. Instead of manipulating the entire DNA string, it's a lot easier to build a list of strings, where each string is 3 base pairs. ["ATG", "GGA", etc. ]. This will save you a lot of multiplying and dividing by 3. Once you've read the comments (both on the PR and under files changed), make a comment to the pull request or send me/Diana an email, letting us know that you've checked them out. Afterwards, close the PR (and optionally delete the graded branch), and we'll give you another 0.5 points. REMEMBER NOT TO MERGE THESE PRs! |
|
I have looked at the suggestions - kevin |
|
thanks and although i didnt do this in hw4, i plan to follow the suggestions and make it more readable. Thanks diana |
2 participants
No description provided.