Only keeping strobemer matches with minimum strobes distance difference#517
Open
NicolasBuchin wants to merge 1 commit intomainfrom
Open
Only keeping strobemer matches with minimum strobes distance difference#517NicolasBuchin wants to merge 1 commit intomainfrom
NicolasBuchin wants to merge 1 commit intomainfrom
Conversation
Collaborator
|
Hi, I’ve run our benchmark on this commit and the previous one and don’t see any difference, not in accuracy but also not in runtime: I therefore suggest to not merge this PR as it just adds (a little bit of) complexity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small change that changes the heuristic on adding strobemer matches, now we just keep the ones with the closest distance to the strobemer hit on the query. Not a very noticeable difference on results but should make chaining a tiny bit faster.