fix(renovate): remove extractVersionTemplate to preserve v prefix in version updates#59
Merged
Merged
Conversation
…version updates extractVersionTemplate was stripping the v prefix when Renovate wrote back updated versions (e.g. v1.22.0 -> 1.23.1 instead of v1.23.1), causing aqua to fail with 404 when trying to install packages by the tag without v prefix. Removing extractVersionTemplate allows versioningTemplate: "semver" to handle v-prefixed versions natively, preserving the v prefix on write-back. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adjusts Renovate configuration so version updates in actions-lint.yml preserve the v prefix (required by aqua/GitHub tag resolution), preventing CI failures caused by unprefixed versions.
Changes:
- Removes
extractVersionTemplatefrom Renovate regex custom manager so updated versions keep thevprefix. - Adds new Serena project configuration fields (
line_ending,read_only_memory_patterns) in.serena/project.yml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/renovate.json5 |
Removes extractVersionTemplate to avoid stripping v from updated versions. |
.serena/project.yml |
Introduces additional Serena project settings (not currently described in the PR summary). |
…rtifacts Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a bug where Renovate's
customManagersconfiguration was stripping thevprefix from version strings when updating tool versions inactions-lint.yml, causinglint / lintCI to fail with a 404 error.Changes
extractVersionTemplatefrom the RenovatecustomManagersconfig in.github/renovate.json5Root Cause
The
extractVersionTemplate: "^v?(?<version>.*)$"setting was stripping thevprefix not only for internal version comparison, but also when writing the updated version back to the file.Before (broken):
ZIZMOR_VERSION="v1.22.0"→ZIZMOR_VERSION="1.23.1"❌After (fixed):
ZIZMOR_VERSION="v1.22.0"→ZIZMOR_VERSION="v1.23.1"✅aqua requires
v-prefixed tags to resolve packages via the GitHub API. Without the prefix, installs fail with404 Not Found.Related Issues
Related PRs that were failing due to this bug:
zizmorcore/zizmorupdate)aquaproj/aqua-registryupdate)Checklist
uses:references are pinned to full commit SHAs (40 characters) with the tag noted in a commentpermissionsare set to the minimum necessaryactionlintlocally and confirmed no errors