Swift3 updates to Markingbird#22
Open
jimstudt wants to merge 6 commits intokristopherjohnson:masterfrom
Open
Conversation
… problem with a self escaping a closure.
…. It was already being forced a few lines above this.
Owner
|
I will merge this in if someone else will resolve the merge conflicts with the current version of master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will update Markingbird for Swift 3 in Xcode 8.2.1.
There is a lot of simple syntax changing and parameter changing.
More significantly, the default immutability of the 'struct' collided heavily with an escaping closure. There may be another way around it, but I changed the Markingbird object to a 'class' instead since it does heavily mutate itself anyway. This could have an impact on clients if they thought they were getting independent copies by copying Markingbird variables.
There are three failures in MDTestTests related to recognizing back ticks and over quoting an ampersand at one point. I don't know if these are new to the Swift3 port.