Skip to content

Implemented feature Kashif #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
getCloudy wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −0
Open

Implemented feature Kashif #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions hello-kashif.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
name='Kashif'
Copy link
Copy Markdown
Owner

@krist00fer krist00fer Jul 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though your Python script works, my code review found this section where you set the variable name to your name, could you please help me understand more, before I approve your PR.

(Thanks for playing along Kashif ;-))

print('Hello, Kashif')