Skip to content

Consolidating changes for PR to s2025 branch#192

Merged
krishauser merged 12 commits intos2025from
s2025_automated_inspection_PR
May 13, 2025
Merged

Consolidating changes for PR to s2025 branch#192
krishauser merged 12 commits intos2025from
s2025_automated_inspection_PR

Conversation

@animeshsingh98
Copy link
Collaborator

@animeshsingh98 animeshsingh98 commented May 10, 2025

  1. The PR has all the changes required for inspection planning and state transition logic
  2. The code by the planning team has been removed in the PR to avoid merge conflicts later.
  3. Launch file for inspection has been included in the PR along with all the changes to the state variables required.
  4. Helper Scripts for Geotagging of images from rosbags and from jpeg files are added.
  5. Script for registering lidar scans based on GNSS initialization and ICP for refinement
  6. Added script to push images and lidar data to s3 bucket

Copy link
Owner

@krishauser krishauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting closer but there are still some nonsensical decisions.

@animeshsingh98 animeshsingh98 requested a review from krishauser May 10, 2025 20:59
@Mhdfk Mhdfk self-assigned this May 13, 2025
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3.0% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link
Owner

@krishauser krishauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krishauser krishauser merged commit 40a1816 into s2025 May 13, 2025
3 of 4 checks passed
@krishauser krishauser deleted the s2025_automated_inspection_PR branch May 13, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants