Skip to content

Sr viz main#181

Closed
Averyyy wants to merge 369 commits intos2025from
sr_viz_main
Closed

Sr viz main#181
Averyyy wants to merge 369 commits intos2025from
sr_viz_main

Conversation

@Averyyy
Copy link
Collaborator

@Averyyy Averyyy commented May 5, 2025

No description provided.

udymd and others added 30 commits February 17, 2025 09:24
Remove ibeo msg in setup_this_machine.sh
Finish klampt_visualization and mpl_visualization in GEMstack/scripts/visualization.py
@Averyyy Averyyy requested a review from krishauser as a code owner May 5, 2025 06:35
# fit a line/plane/hyperplane in a pointcloud
# pc: np array (N,D). the pointcloud
# tol: the tolerance. default 0.01
model = RANSACRegressor(LinearRegression(), residual_threshold=tol)

Check notice

Code scanning / SonarCloud

Results that depend on random number generation should be reproducible Low

Provide a seed for the random\_state parameter. See more on SonarQube Cloud

# Check if plots have been previously generated
if os.path.exists(cache_file):
with open(cache_file, "r") as f:

Check failure

Code scanning / SonarCloud

I/O function calls should not be vulnerable to path injection attacks High

Change this code to not construct the path from user-controlled data. See more on SonarQube Cloud
trajectory_data = []

# Parse behavior file
with open(behavior_file, "r") as f:

Check failure

Code scanning / SonarCloud

I/O function calls should not be vulnerable to path injection attacks High

Change this code to not construct the path from user-controlled data. See more on SonarQube Cloud

# Cache plot file paths
plot_files = {"comprehensive": plot_path}
with open(cache_file, "w") as f:

Check failure

Code scanning / SonarCloud

I/O function calls should not be vulnerable to path injection attacks High

Change this code to not construct the path from user-controlled data. See more on SonarQube Cloud
log_folder_path = os.path.join(LOG_DIR, log_folder)

# Find behavior.json file
behavior_files = [f for f in os.listdir(log_folder_path) if f == "behavior.json"]

Check failure

Code scanning / SonarCloud

I/O function calls should not be vulnerable to path injection attacks High

Change this code to not construct the path from user-controlled data. See more on SonarQube Cloud
if not full_path.startswith(os.path.abspath(LOG_DIR)):
return "Invalid path", 400
if not os.path.isdir(full_path):
return f"Folder does not exist: {folder}", 404

Check failure

Code scanning / SonarCloud

Endpoints should not be vulnerable to reflected cross-site scripting (XSS) attacks High

Change this code to not reflect user-controlled data. See more on SonarQube Cloud

try:
if platform.system() == "Windows":
os.system(f'explorer "{full_path}"')

Check failure

Code scanning / SonarCloud

OS commands should not be vulnerable to command injection attacks High

Change this code to not construct the OS command from user-controlled data. See more on SonarQube Cloud
if platform.system() == "Windows":
os.system(f'explorer "{full_path}"')
elif platform.system() == "Linux":
os.system(f'xdg-open "{full_path}"')

Check failure

Code scanning / SonarCloud

OS commands should not be vulnerable to command injection attacks High

Change this code to not construct the OS command from user-controlled data. See more on SonarQube Cloud
elif platform.system() == "Linux":
os.system(f'xdg-open "{full_path}"')
elif platform.system() == "Darwin":
os.system(f'open "{full_path}"')

Check failure

Code scanning / SonarCloud

OS commands should not be vulnerable to command injection attacks High

Change this code to not construct the OS command from user-controlled data. See more on SonarQube Cloud
page = request.args.get("page", 1, type=int)

try:
with open(file_path, "r") as f:

Check failure

Code scanning / SonarCloud

I/O function calls should not be vulnerable to path injection attacks High

Change this code to not construct the path from user-controlled data. See more on SonarQube Cloud
Copy link
Owner

@krishauser krishauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are way too many files that are included here that are not relevant to the contribution (and are even regressions). Please reduce this to the minimal set of files needed to add the functionality that you are proposing.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change this?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This conflicts with where perception is going to store the camera calibrations

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not relevant

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
19 Security Hotspots
E Reliability Rating on New Code (required ≥ A)
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@Averyyy Averyyy closed this May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.