Skip to content

Small refactor to s2025_perception_merge_Tianyu#175

Merged
Ren990420 merged 3 commits intos2025_perception_merge_Tianyufrom
sensor_fusion_tianyu
May 2, 2025
Merged

Small refactor to s2025_perception_merge_Tianyu#175
Ren990420 merged 3 commits intos2025_perception_merge_Tianyufrom
sensor_fusion_tianyu

Conversation

@LucasEby
Copy link
Collaborator

@LucasEby LucasEby commented May 2, 2025

I needed to move the cone_detection.py helper functions into their own utility file (perception_utils.py) so the sensor fusion sub group can use them easier. I additionally threw in some small refactors that should hopefully make the cone_detection.py file easier to work with:

  • Added some comments to explain complicated sections of the cone_detection.py code
  • Moved the file saving functionality in cone_detection.py to it's own function to reduce the size of the update function

I tested that the code performed the same way after the changes with the following commands:
roscore
rosbag play -l multiple_slanted_w_obstacle.bag
python3 main.py --variant=detector_only launch/cone_detection.yaml

@LucasEby LucasEby requested a review from Ren990420 May 2, 2025 19:04
@LucasEby LucasEby requested a review from krishauser as a code owner May 2, 2025 19:04
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 2, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
62.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@Ren990420 Ren990420 merged commit 24e0e3f into s2025_perception_merge_Tianyu May 2, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants