S2025 perception cone detector 1st PR#172
Merged
krishauser merged 28 commits intos2025from May 12, 2025
Merged
Conversation
changed AgentState to ObstacleState, and also changed the corresponding yaml file
moved the l2v to cameras.yaml
moved l2v here
no longer changing this file
krishauser
requested changes
May 9, 2025
Owner
There was a problem hiding this comment.
You should be using an Obstacle, not at Agent: https://github.com/krishauser/GEMstack/blob/main/GEMstack/state/obstacle.py
Owner
There was a problem hiding this comment.
Pose_to_matrix(pose) can be replaced by pose.transform()
Owner
There was a problem hiding this comment.
Obstacles don't move. Don't include the values relevant to agents.
Owner
There was a problem hiding this comment.
Wait, why are you creating a different obstacle state class? This seems to have been copied from Agent without thinking.
Updated enums in Obstacle
removed ObstacleState amd redundant StateEnum
removed to_frame. Physical Object already has a to_frame function
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cone detector has been successfully tested and integrated by parking team. Verticals can use cone_detection.yaml to change cone detection settings such as which camera to use. Camera matrix is now stored in a separate yaml file.