You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
This is not an appropriate place to be putting launch control. It should be in a controller behavior that either takes effect when starting from a stop, or is triggerable with a flag. There needs to be a way to switch away from launch control as well.
This is not an appropriate place to be putting launch control. It should be in a controller behavior that either takes effect when starting from a stop, or is triggerable with a flag. There needs to be a way to switch away from launch control as well.
@Adi9103 please integrate this feedback into Stanley controller
We will probably need to modify GEM_hardware.py to either take a signal for launch control or take brake and throttle at the same time. Please talk to control team once we have some changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added launch control as a toggle-able feature
Stage duration is how long each of max brake, max throttle and brake, max throttle is enabled