Skip to content

Launch control pr#161

Closed
laneccolin wants to merge 2 commits intos2025from
launchControlPR
Closed

Launch control pr#161
laneccolin wants to merge 2 commits intos2025from
launchControlPR

Conversation

@laneccolin
Copy link
Collaborator

Added launch control as a toggle-able feature
Stage duration is how long each of max brake, max throttle and brake, max throttle is enabled

@laneccolin laneccolin requested a review from krishauser as a code owner April 16, 2025 04:38
@sonarqubecloud
Copy link

Copy link
Owner

@krishauser krishauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not an appropriate place to be putting launch control. It should be in a controller behavior that either takes effect when starting from a stop, or is triggerable with a flag. There needs to be a way to switch away from launch control as well.

@laneccolin
Copy link
Collaborator Author

This is not an appropriate place to be putting launch control. It should be in a controller behavior that either takes effect when starting from a stop, or is triggerable with a flag. There needs to be a way to switch away from launch control as well.

@Adi9103 please integrate this feedback into Stanley controller
We will probably need to modify GEM_hardware.py to either take a signal for launch control or take brake and throttle at the same time. Please talk to control team once we have some changes.

@laneccolin laneccolin closed this Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants