You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think this looks good. Maybe the only thing would be changing the .gitignore so that it doesn't check all of the logs and plots into the repo
If you leave log folder attribute in launch yaml file as default, logs, then it won't check anything into the repo. So I think changing the .gitignore is unnecessary?
If you leave log folder attribute in launch yaml file as default, logs, then it won't check anything into the repo. So I think changing the .gitignore is unnecessary?
I just noticed a few pngs checked into the PR. If you manually checked those in it's probably fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for generating plots and metrics from
PurePursuitTrajectoryTracker_debug.csvusingauto_plotattribute after each run in launch yaml file.