Skip to content

Infra a auto plot#139

Merged
Averyyy merged 8 commits intos2025_teamAfrom
infra_a_auto_plot
Feb 25, 2025
Merged

Infra a auto plot#139
Averyyy merged 8 commits intos2025_teamAfrom
infra_a_auto_plot

Conversation

@Jason717717
Copy link
Collaborator

Add support for generating plots and metrics from PurePursuitTrajectoryTracker_debug.csv using auto_plot attribute after each run in launch yaml file.

Copy link
Collaborator

@alo-20 alo-20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. Maybe the only thing would be changing the .gitignore so that it doesn't check all of the logs and plots into the repo

@Jason717717
Copy link
Collaborator Author

I think this looks good. Maybe the only thing would be changing the .gitignore so that it doesn't check all of the logs and plots into the repo

If you leave log folder attribute in launch yaml file as default, logs, then it won't check anything into the repo. So I think changing the .gitignore is unnecessary?

@alo-20
Copy link
Collaborator

alo-20 commented Feb 25, 2025

If you leave log folder attribute in launch yaml file as default, logs, then it won't check anything into the repo. So I think changing the .gitignore is unnecessary?

I just noticed a few pngs checked into the PR. If you manually checked those in it's probably fine

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
43.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@Averyyy
Copy link
Collaborator

Averyyy commented Feb 25, 2025

lgtm

@Averyyy Averyyy merged commit 66d2069 into s2025_teamA Feb 25, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants