Perception b center agent states suggestions#113
Closed
LucasEby wants to merge 6 commits intoPerceptionB_center_agent_statesfrom
Closed
Perception b center agent states suggestions#113LucasEby wants to merge 6 commits intoPerceptionB_center_agent_statesfrom
LucasEby wants to merge 6 commits intoPerceptionB_center_agent_statesfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created AgentTracker.py, IdTracker.py, and LostAgent.py to help Akul out with his tasking. I added it to this PR so you are aware of what he's doing. I think it would be best to have him work in a separate class for what he's doing (at least for now) so you guys don't step on each other's toes. Also he should be able to test his code without ROS, I think that will help him out. I'm hoping this will make it easier to integrate his stuff into what you are doing later.
I tried to move most of the ROS stuff into pedestrian_detection.py. I think we should have PedestrianDetector2D's detect_pedestrians method call Fusion3D's fusion_callback function inside of it. I figure this way we can have the fusing of the data abstracted out from the rest of what we have to do. So detect_pedestrians would basically be a "main method" that calls the other stuff we need. Might make the code a bit easier to understand?
Tbh I'm not 100% sure what all fusion.py is doing so I felt that stopping here would be a good idea to get your opinion since I don't fully understand everything about fusion.py